Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Oct 2022 15:52:15 +0200
From:   Marcus Folkesson <marcus.folkesson@gmail.com>
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Kent Gustavsson <kent@minoris.se>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: mcp3911: Fix out of bounds access of array
 mcp3911_osr_table
Message-ID: <Y0bGjwBBt4LZRACd@gmail.com>
References: <20221012134245.5345-1-colin.i.king@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="5nSA75CLaUsFpwFr"
Content-Disposition: inline
In-Reply-To: <20221012134245.5345-1-colin.i.king@gmail.com>
Precedence: bulk


--5nSA75CLaUsFpwFr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Colin,

On Wed, Oct 12, 2022 at 02:42:45PM +0100, Colin Ian King wrote:
> Currently the for-loop is using the size of the array mcp3911_osr_table
> as the upper bounds which is 0..31 which is causing an out of bounds
> access to the array at indexes 8..31. Fix this using the ARRAY_SIZE
> macro to get the size of the array in elements rather than bytes.
>=20
> Fixes: 6d965885f4ea ("iio: adc: mcp3911: add support for oversampling rat=
io")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Thank you for the patch!

Dan was a little bit earlier to catch this though
https://lore.kernel.org/all/20221002132053.113f595f@jic23-huawei/

Best regards,
Marcus Folkesson

--5nSA75CLaUsFpwFr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmNGxooACgkQiIBOb1ld
UjK6qRAA1rF7nxVVSdzREFmdFoVX0pepJFiU/yFdWzV9YtGYc3DG9UUr1wdJrN1l
DnVKu9knsxdGz9U+p4kBZxcp5ZqnMrqa+wkm2iYErDM4NeS/ZZNl/g+6vQL+i9yw
0U4CWoM9lzt1k1TkyTsv0qvv0mHMPup++c4EyOqOBJhAcew5vFVt6LjLZWwc3zaX
57BevVaDjE1ZFe1rj4d8MrbVdml7Os5E9vbuStqOMGz0SCKrJWSjvz7L5z7YGHrL
r8XouK0DNHGfbXmp4uW9Jj1ZO1fkq2Jh/lwGnSEcUDRTk0cuwsmh84Au4mtBOiWU
jnVqqhi3tCdeXY5Q7F3eiHeqyFO9PVb77DlwxTSw6+GGpI2jXJUuTYmIid/CWfHo
nQ/wb0yzUzWFPhSIGEOZjbqKSYjIF3g4M0H2hxWEpLMceQuhKo3aLxd9PxaUtE8l
X0/bMJNpjQa5Z/vf0fBY+tuEQMG3mkTN4h35sytcZoEQyOcKduGdXuMit0Uzma3m
LxlKZyKKhvNisSmWWe8oEEb+5V2umsgJiJ3c9Y2KQ5txHupUVpDXTD0oneg3Bqsn
vIy6J2AQzcms/4azildTz9r6HCkU3oL6jbEVk4R9PCjgq4Kg8kPyD+Wnp32oteW6
QGHa+RXIAh7adacB9Lh3fImBLCDX5Wzlj77NQFWS4zLdoj8pSX4=
=HgeC
-----END PGP SIGNATURE-----

--5nSA75CLaUsFpwFr--