Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760103AbXF0Mt4 (ORCPT ); Wed, 27 Jun 2007 08:49:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757813AbXF0Mtt (ORCPT ); Wed, 27 Jun 2007 08:49:49 -0400 Received: from sovereign.computergmbh.de ([85.214.69.204]:15901 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757017AbXF0Mts (ORCPT ); Wed, 27 Jun 2007 08:49:48 -0400 Date: Wed, 27 Jun 2007 14:49:47 +0200 (CEST) From: Jan Engelhardt To: Trilok Soni cc: apw@uk.ibm.com, linux-kernel@vger.kernel.org Subject: Re: checkpatch: need space before that '*' (ctx:BxB) In-Reply-To: <5d5443650706270454v443d1ac7qee6475bc31af844f@mail.gmail.com> Message-ID: References: <5d5443650706270454v443d1ac7qee6475bc31af844f@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 781 Lines: 23 On Jun 27 2007 17:24, Trilok Soni wrote: > > In the following case we may not need space before that "(*)". It > looks like false positive. Please check. > > need space before that '*' (ctx:BxB) > #1034: FILE: drivers/video/omap/omapfb.c:968: > + omapfb_nb->nb.notifier_call = (int (*)(struct notifier_block *, > ^ The line, as presented in your mail, is already correct Keep the space between "int" and "(*)" :-) [follows how you'd declare a normal variable] Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/