Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Oct 2022 17:54:07 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Saurabh Sengar <ssengar@linux.microsoft.com>
Cc:     ssengar@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com,
        sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
        longli@microsoft.com, linux-hyperv@vger.kernel.org,
        linux-kernel@vger.kernel.org, mikelley@microsoft.com
Subject: Re: [PATCH] uio_hv_generic: Enable support for slower vmbus device
 channels
Message-ID: <Y0bjH+k3G6V45WRT@kroah.com>
References: <1665575806-27990-1-git-send-email-ssengar@linux.microsoft.com>
 <Y0bipdisMbTNMYOq@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y0bipdisMbTNMYOq@kroah.com>
Precedence: bulk

On Wed, Oct 12, 2022 at 05:52:05PM +0200, Greg KH wrote:
> On Wed, Oct 12, 2022 at 04:56:46AM -0700, Saurabh Sengar wrote:
> > This patch enables support for slower vmbus channels, which consist
> > of following 3 changes :
> > 	1. Support for hypercalls
> > 	2. Module params for recv/send buffer sizes
> > 	3. Module param for custom ring buffer sizes
> 
> Even if this all was ok, you are doing 3 things all in one change,
> that's not allowed at all, you all know this.
> 
> Anyway, no new module parameters, this is not the 1990's, we have much
> better ways to do this properly (hint, module parameters modify code,
> you want to modify the options of a specific device.)

Also, you give no good reason for why this is needed at all, nor how
anyone would use these options and why they would need to.

The kernel should "just work" and not require manual intervention by a
user.  Dynamically fix this based on the device, do NOT force a user to
have to attempt to "tune" anything, that will never work properly over
time, AND you are being lazy and forcing each individual user to do the
work, making more effort needed overall than just doing it properly in
the kernel.

thanks,

greg k-h