Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Oct 2022 18:23:31 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc:     Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        Shuah Khan <shuah@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        "H . Peter Anvin" <hpa@zytor.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Kai Huang <kai.huang@intel.com>,
        Wander Lairson Costa <wander@redhat.com>,
        Isaku Yamahata <isaku.yamahata@gmail.com>,
        marcelo.cerri@canonical.com, tim.gardner@canonical.com,
        khalid.elmously@canonical.com, philip.cox@canonical.com,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-doc@vger.kernel.org
Subject: Re: [PATCH v14 1/3] x86/tdx: Make __tdx_module_call() usable in
 driver module
Message-ID: <Y0bqA8+Xi1kLchxh@kroah.com>
References: <20220928215535.26527-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <20220928215535.26527-2-sathyanarayanan.kuppuswamy@linux.intel.com>
 <Y0aUb3n7ouaeAt2a@zn.tnic>
 <acc212d6-782b-a398-825a-212849beba00@linux.intel.com>
 <Y0bOtzlrkKzHmQVZ@zn.tnic>
 <6759025f-fc08-74f0-efd7-2331110dec0c@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6759025f-fc08-74f0-efd7-2331110dec0c@linux.intel.com>
Precedence: bulk

On Wed, Oct 12, 2022 at 08:44:04AM -0700, Sathyanarayanan Kuppuswamy wrote:
> 
> 
> On 10/12/22 7:27 AM, Borislav Petkov wrote:
> > On Wed, Oct 12, 2022 at 06:35:56AM -0700, Sathyanarayanan Kuppuswamy wrote:
> >> So we should create a new wrapper for this use case or use
> > 
> > Yes, you got it - a new wrapper pls.
> 
> Ok. I will add a new wrapper to get the TDREPORT. 
> 
> +/*
> 
> + * Add a wrapper for TDG.MR.REPORT TDCALL. It is used in TDX guest
> 
> + * driver module to get the TDREPORT.
> 
> + */
> 
> +long tdx_mcall_get_report(void *reportdata, void *tdreport, u8 subtype)

Why "long"?

Why void *?  Don't you have real types for these?


> 
> +{
> 
> +       if (subtype || !reportdata || !tdreport)
> 
> +               return -EINVAL;

How could that happen if you control all callers?


> 
> +
> 
> +       /*
> 
> +        * Generate TDREPORT using "TDG.MR.REPORT" TDCALL.
> 
> +        *
> 
> +        * Get the TDREPORT using REPORTDATA as input. Refer to
> 
> +        * section 22.3.3 TDG.MR.REPORT leaf in the TDX Module 1.0
> 
> +        * specification for detailed information.
> 
> +        */
> 
> +       return __tdx_module_call(TDX_GET_REPORT, virt_to_phys(tdreport),
> 
> +                       virt_to_phys(reportdata), subtype, 0, NULL);

If you check for NULL, why are you not validating that these are valid
pointers as well?  You can't have it both ways.

thanks,

greg k-h