Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Oct 2022 10:57:17 -0700
From:   Peilin Ye <yepeilin.cs@gmail.com>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Peilin Ye <peilin.ye@bytedance.com>,
        Cong Wang <cong.wang@bytedance.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] net/sock: Introduce trace_sk_data_ready()
Message-ID: <20221012175717.GA26425@bytedance>
References: <20221007221038.2345-1-yepeilin.cs@gmail.com>
 <20221011195856.13691-1-yepeilin.cs@gmail.com>
 <Y0ZXiDiqxYb7yYmS@unreal>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y0ZXiDiqxYb7yYmS@unreal>
Precedence: bulk

On Wed, Oct 12, 2022 at 08:58:32AM +0300, Leon Romanovsky wrote:
> > +	trace_sk_data_ready(sk, __func__);
> >  	pr_debug("Entering iscsi_target_sk_data_ready: conn: %p\n", conn);
> 
> This can go.

<...>

> __func__ repetitive pattern hints that it is not best API interface.
> 
> 
> > +TRACE_EVENT(sk_data_ready,
> > +
> > +	TP_PROTO(const struct sock *sk, const char *func),
> > +
> > +	TP_ARGS(sk, func),
> > +
> > +	TP_STRUCT__entry(
> > +		__field(const void *, skaddr)
> > +		__field(__u16, family)
> > +		__field(__u16, protocol)
> > +		__string(func, func)
> 
> TRACE_EVENT() is macro defined in .h file, you can safely put __func__
> instead.

Thanks for the suggestions!  I will update in v4.

Peilin Ye