Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221011180142.2742289-1-joel@joelfernandes.org>
 <20221011180142.2742289-3-joel@joelfernandes.org> <20221011231053.GA1052831@lothringen>
In-Reply-To: <20221011231053.GA1052831@lothringen>
From:   Joel Fernandes <joel@joelfernandes.org>
Date:   Wed, 12 Oct 2022 15:54:25 -0400
Message-ID: <CAEXW_YSsEQ8krr9ckCOmO1B=C+Oy+8j_BtetQeNu1McH5nSuQg@mail.gmail.com>
Subject: Re: [PATCH v8 02/13] rcu: Make call_rcu() lazy to save power
To:     Frederic Weisbecker <frederic@kernel.org>
Cc:     rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
        rushikesh.s.kadam@intel.com, urezki@gmail.com,
        neeraj.iitr10@gmail.com, paulmck@kernel.org, rostedt@goodmis.org,
        youssefesmat@google.com, surenb@google.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 11, 2022 at 7:10 PM Frederic Weisbecker <frederic@kernel.org> wrote:
>
> On Tue, Oct 11, 2022 at 06:01:31PM +0000, Joel Fernandes (Google) wrote:
> > @@ -269,10 +294,14 @@ static void wake_nocb_gp_defer(struct rcu_data *rdp, int waketype,
> >       raw_spin_lock_irqsave(&rdp_gp->nocb_gp_lock, flags);
> >
> >       /*
> > -      * Bypass wakeup overrides previous deferments. In case
> > -      * of callback storm, no need to wake up too early.
> > +      * Bypass wakeup overrides previous deferments. In case of
> > +      * callback storm, no need to wake up too early.
> >        */
> > -     if (waketype == RCU_NOCB_WAKE_BYPASS) {
> > +     if (waketype == RCU_NOCB_WAKE_LAZY &&
> > +         READ_ONCE(rdp->nocb_defer_wakeup) == RCU_NOCB_WAKE_NOT) {
>
> No need for READ_ONCE() here.
>
> > +             mod_timer(&rdp_gp->nocb_timer, jiffies + jiffies_till_flush);
> > +             WRITE_ONCE(rdp_gp->nocb_defer_wakeup, waketype);
> > +     } else if (waketype == RCU_NOCB_WAKE_BYPASS) {
> >               mod_timer(&rdp_gp->nocb_timer, jiffies + 2);
> >               WRITE_ONCE(rdp_gp->nocb_defer_wakeup, waketype);
> >       } else {
> > @@ -611,6 +682,8 @@ static void nocb_gp_wait(struct rcu_data *my_rdp)
> >       unsigned long flags;
> >       bool gotcbs = false;
> >       unsigned long j = jiffies;
> > +     bool lazy = false;
> > +     long lazy_ncbs;
>
> Looks like lazy_ncbs can be declared withing the loop, as well as bypass_cbs.
>
> Anyway, apart from such boring cosmectics:
>
> Acked-by: Frederic Weisbecker <frederic@kernel.org>

Thanks, I folded the cosmetic suggestions with the Ack and pushed it to:
https://github.com/joelagnel/linux-kernel.git (branch rcu-next-oct.12.22)

thanks,

 - Joel