Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <116bc168-0c0d-7d61-976e-1e110166e7fd@quicinc.com>
Date:   Wed, 12 Oct 2022 13:32:28 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 4/5] soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains
Content-Language: en-US
To:     Bjorn Andersson <andersson@kernel.org>
CC:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Bhupesh Sharma <bhupesh.sharma@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20221001030641.29354-1-quic_molvera@quicinc.com>
 <20221001030641.29354-5-quic_molvera@quicinc.com>
 <20221007031147.vjzfipbroo3gnohz@builder.lan>
From:   Melody Olvera <quic_molvera@quicinc.com>
In-Reply-To: <20221007031147.vjzfipbroo3gnohz@builder.lan>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/6/2022 8:11 PM, Bjorn Andersson wrote:
> On Fri, Sep 30, 2022 at 08:06:40PM -0700, Melody Olvera wrote:
>> Add the power domains exposed by RPMH in the Qualcomm QDU1000
>> and QRU1000 platforms.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>  drivers/soc/qcom/rpmhpd.c | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
>> index 092f6ab09acf..f70573cbc636 100644
>> --- a/drivers/soc/qcom/rpmhpd.c
>> +++ b/drivers/soc/qcom/rpmhpd.c
>> @@ -353,6 +353,19 @@ static const struct rpmhpd_desc sm8450_desc = {
>>  	.num_pds = ARRAY_SIZE(sm8450_rpmhpds),
>>  };
>>  
>> +/* QDU1000/QRU1000 RPMH powerdomains */
>> +static struct rpmhpd *qdru1000_rpmhpds[] = {
>> +	[QDRU1000_CX] = &cx,
>> +	[QDRU1000_EBI] = &ebi,
>> +	[QDRU1000_MSS] = &mss,
>> +	[QDRU1000_MX] = &mx,
>> +};
>> +
>> +static const struct rpmhpd_desc qdru1000_desc = {
>> +	.rpmhpds = qdru1000_rpmhpds,
>> +	.num_pds = ARRAY_SIZE(qdru1000_rpmhpds),
>> +};
>> +
> Looks like you missed adding a (or two) entires to rpmhpd_match_table.
So I did. Will add.
>
> Regards,
> Bjorn
>
>>  /* SC7180 RPMH powerdomains */
>>  static struct rpmhpd *sc7180_rpmhpds[] = {
>>  	[SC7180_CX] = &cx_w_mx_parent,
>> -- 
>> 2.37.3
>>
Thanks,
Melody