Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Oct 2022 14:51:52 -0700
From:   Kees Cook <keescook@chromium.org>
To:     "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc:     linux-hardening@vger.kernel.org,
        Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>,
        Paramjit Oberoi <pso@chromium.org>,
        Ard Biesheuvel <ardb@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] pstore/ram: Move internal definitions out of
 kernel-wide include
Message-ID: <202210121451.7CEC6637@keescook>
References: <20221011200112.731334-1-keescook@chromium.org>
 <20221011200112.731334-4-keescook@chromium.org>
 <5fdffa8b-04cb-b42f-e29a-03e9e9045424@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5fdffa8b-04cb-b42f-e29a-03e9e9045424@igalia.com>
Precedence: bulk

On Wed, Oct 12, 2022 at 04:46:44PM -0300, Guilherme G. Piccoli wrote:
> On 11/10/2022 17:01, Kees Cook wrote:
> > Most of the details of the ram backend are entirely internal to the
> > backend itself. Leave only what is needed to instantiate a ram backend
> > in the kernel-wide header.
> > 
> > Cc: Anton Vorontsov <anton@enomsg.org>
> > Cc: Colin Cross <ccross@android.com>
> > Cc: Tony Luck <tony.luck@intel.com>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> > ---
> 
> Reviewed-and-tested-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> 
> Tested by building and booting the kernel - since it's just header file
> rework, guess this is enough right?
> 
> BTW, let me know if you prefer me to respond on the series once or per
> patch Kees (as I'm doing here).

Thanks! Yeah, per-patch is good. :)

-- 
Kees Cook