Subject: Re: [PATCH 16/16] fix handling of integer constant expressions
From: Josh Triplett <josht@linux.vnet.ibm.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Neil Booth <neil@daikokuya.co.uk>, Josh Triplett <josh@freedesktop.org>,
       Segher Boessenkool <segher@kernel.crashing.org>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       linux-kernel@vger.kernel.org, linux-sparse@vger.kernel.org
In-Reply-To: <20070627131823.GR21478@ftp.linux.org.uk>
References: <20070624183547.GA21478@ftp.linux.org.uk>
	 <alpine.LFD.0.98.0706241203530.3593@woody.linux-foundation.org>
	 <1a25667a20e43a072f733a3ec2b8e79d@kernel.crashing.org>
	 <20070624203837.GE21478@ftp.linux.org.uk>
	 <467F531A.3030702@freedesktop.org>
	 <20070626221040.GI21478@ftp.linux.org.uk>
	 <20070626221134.GA21350@ftp.linux.org.uk>
	 <20070627121021.GQ7590@daikokuya.co.uk>
	 <20070627123031.GO21478@ftp.linux.org.uk>
	 <20070627125958.GA16758@daikokuya.co.uk>
	 <20070627131823.GR21478@ftp.linux.org.uk>
Content-Type: text/plain
Date: Wed, 27 Jun 2007 07:50:18 -0700
Message-Id: <1182955818.8970.28.camel@josh-work.beaverton.ibm.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 932
Lines: 31

On Wed, 2007-06-27 at 14:18 +0100, Al Viro wrote:
> --- a/expand.c
> +++ b/expand.c
[...]
> @@ -488,12 +490,15 @@ static int expand_conditional(struct expression *expr)
> 
>  	cond_cost = expand_expression(cond);
>  	if (cond->type == EXPR_VALUE) {
> +		unsigned flags = expr->flags;
>  		if (!cond->value)
>  			true = false;
>  		if (!true)
>  			true = cond;
> +		cost = expand_expression(*true);
>  		*expr = *true;
> -		return expand_expression(expr);
> +		expr->flags = flags;
> +		return cost;

This passes an incorrect type to expand_expression; it wants a struct
expression *, but *true has type struct expression; did you want to pass
true rather than *true?

- Josh Triplett


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/