Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <611e9bed-df6a-0da9-fbf9-4046f4211a7d@linux.dev>
Date:   Wed, 12 Oct 2022 16:17:51 -0700
MIME-Version: 1.0
Subject: Re: [PATCH bpf-next v4 5/6] selftests/bpf: Fix error failure of case
 test_xdp_adjust_tail_grow
Content-Language: en-US
To:     Xu Kuohai <xukuohai@huaweicloud.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Kumar Kartikeya Dwivedi <memxor@gmail.com>,
        Alan Maguire <alan.maguire@oracle.com>,
        Delyan Kratunov <delyank@fb.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        netdev@vger.kernel.org
References: <20221011120108.782373-1-xukuohai@huaweicloud.com>
 <20221011120108.782373-6-xukuohai@huaweicloud.com>
From:   Martin KaFai Lau <martin.lau@linux.dev>
In-Reply-To: <20221011120108.782373-6-xukuohai@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/11/22 5:01 AM, Xu Kuohai wrote:
> From: Xu Kuohai <xukuohai@huawei.com>
> 
> test_xdp_adjust_tail_grow failed with ipv6:
>    test_xdp_adjust_tail_grow:FAIL:ipv6 unexpected error: -28 (errno 28)
> 
> The reason is that this test case tests ipv4 before ipv6, and when ipv4
> test finished, topts.data_size_out was set to 54, which is smaller than the
> ipv6 output data size 114, so ipv6 test fails with NOSPC error.
> 
> Fix it by reset topts.data_size_out to sizeof(buf) before testing ipv6.
> 
> Fixes: 04fcb5f9a104 ("selftests/bpf: Migrate from bpf_prog_test_run")
> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
> ---
>   tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c b/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c
> index 9b9cf8458adf..009ee37607df 100644
> --- a/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c
> +++ b/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c
> @@ -63,6 +63,7 @@ static void test_xdp_adjust_tail_grow(void)
>   	expect_sz = sizeof(pkt_v6) + 40; /* Test grow with 40 bytes */
>   	topts.data_in = &pkt_v6;
>   	topts.data_size_in = sizeof(pkt_v6);
> +	topts.data_size_out = sizeof(buf);

lgtm but how was it working before... weird.

>   	err = bpf_prog_test_run_opts(prog_fd, &topts);
>   	ASSERT_OK(err, "ipv6");
>   	ASSERT_EQ(topts.retval, XDP_TX, "ipv6 retval");