Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE: [PATCH] drivers/extcon: use simple i2c probe
Reply-To: myungjoo.ham@samsung.com
Sender: MyungJoo Ham <myungjoo.ham@samsung.com>
From:   MyungJoo Ham <myungjoo.ham@samsung.com>
To:     Stephen Kitt <steve@sk2.org>, Chanwoo Choi <cw00.choi@samsung.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <20221012141846.3916480-1-steve@sk2.org>
Message-ID: <20221013022519epcms1p555f11b5f130e6991017dd76741ad583f@epcms1p5>
Date:   Thu, 13 Oct 2022 11:25:19 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20221012141846.3916480-1-steve@sk2.org>
        <CGME20221012141859epcas1p16f5cfc50d6d0404e8fc07a4ac50f46a2@epcms1p5>
Precedence: bulk

>=20
> --------- Original Message ---------
> Sender : Stephen Kitt=C2=A0<steve=40sk2.org>=0D=0A>=20Date=20:=202022-10-=
12=2023:18=20(GMT+9)=0D=0A>=20Title=20:=20=5BPATCH=5D=20drivers/extcon:=20u=
se=20simple=20i2c=20probe=0D=0A>=20=C2=A0=0D=0A>=20All=C2=A0these=C2=A0driv=
ers=C2=A0have=C2=A0an=C2=A0i2c=C2=A0probe=C2=A0function=C2=A0which=C2=A0doe=
sn't=C2=A0use=C2=A0the=0D=0A>=20=22struct=C2=A0i2c_device_id=C2=A0*id=22=C2=
=A0parameter,=C2=A0so=C2=A0they=C2=A0can=C2=A0trivially=C2=A0be=0D=0A>=20co=
nverted=C2=A0to=C2=A0the=C2=A0=22probe_new=22=C2=A0style=C2=A0of=C2=A0probe=
=C2=A0with=C2=A0a=C2=A0single=C2=A0argument.=0D=0A>=20=0D=0A>=20This=C2=A0i=
s=C2=A0part=C2=A0of=C2=A0an=C2=A0ongoing=C2=A0transition=C2=A0to=C2=A0singl=
e-argument=C2=A0i2c=C2=A0probe=0D=0A>=20functions.=C2=A0Old-style=C2=A0prob=
e=C2=A0functions=C2=A0involve=C2=A0a=C2=A0call=C2=A0to=C2=A0i2c_match_id:=
=0D=0A>=20in=C2=A0drivers/i2c/i2c-core-base.c,=0D=0A>=20=0D=0A>=20=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/*=0D=0A>=20=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0*=C2=A0When=C2=A0there=C2=A0are=
=C2=A0no=C2=A0more=C2=A0users=C2=A0of=C2=A0probe(),=0D=0A>=20=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0*=C2=A0rename=C2=A0probe_ne=
w=C2=A0to=C2=A0probe.=0D=0A>=20=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0*/=0D=0A>=20=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0if=C2=A0(driver->probe_new)=0D=0A>=20=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
status=C2=A0=3D=C2=A0driver->probe_new(client);=0D=0A>=20=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0else=C2=A0if=C2=A0(driver->probe)=0D=0A=
>=20=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0status=C2=A0=3D=C2=A0driver->probe(client,=
=0D=0A>=20=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0i2c_match_id(driver->id_table,=C2=A0client));=0D=
=0A>=20=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0else=0D=0A>=20=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0status=C2=A0=3D=C2=A0-EINVAL;=0D=0A>=20=0D=0A>=
=20Drivers=C2=A0which=C2=A0don't=C2=A0need=C2=A0the=C2=A0second=C2=A0parame=
ter=C2=A0can=C2=A0be=C2=A0declared=C2=A0using=0D=0A>=20probe_new=C2=A0inste=
ad,=C2=A0avoiding=C2=A0the=C2=A0call=C2=A0to=C2=A0i2c_match_id.=C2=A0Driver=
s=C2=A0which=C2=A0do=0D=0A>=20can=C2=A0still=C2=A0be=C2=A0converted=C2=A0to=
=C2=A0probe_new-style,=C2=A0calling=C2=A0i2c_match_id=0D=0A>=20themselves=
=C2=A0(as=C2=A0is=C2=A0done=C2=A0currently=C2=A0for=C2=A0of_match_id).=0D=
=0A>=20=0D=0A>=20This=C2=A0change=C2=A0was=C2=A0done=C2=A0using=C2=A0the=C2=
=A0following=C2=A0Coccinelle=C2=A0script,=C2=A0and=C2=A0fixed=0D=0A>=20up=
=C2=A0for=C2=A0whitespace=C2=A0changes:=0D=0A>=20=0D=0A>=20=40=C2=A0rule1=
=C2=A0=40=0D=0A>=20identifier=C2=A0fn;=0D=0A>=20identifier=C2=A0client,=C2=
=A0id;=0D=0A>=20=40=40=0D=0A>=20=0D=0A>=20-=C2=A0static=C2=A0int=C2=A0fn(st=
ruct=C2=A0i2c_client=C2=A0*client,=C2=A0const=C2=A0struct=C2=A0i2c_device_i=
d=C2=A0*id)=0D=0A>=20+=C2=A0static=C2=A0int=C2=A0fn(struct=C2=A0i2c_client=
=C2=A0*client)=0D=0A>=20=7B=0D=0A>=20...when=C2=A0=21=3D=C2=A0id=0D=0A>=20=
=7D=0D=0A>=20=0D=0A>=20=40=C2=A0rule2=C2=A0depends=C2=A0on=C2=A0rule1=C2=A0=
=40=0D=0A>=20identifier=C2=A0rule1.fn;=0D=0A>=20identifier=C2=A0driver;=0D=
=0A>=20=40=40=0D=0A>=20=0D=0A>=20struct=C2=A0i2c_driver=C2=A0driver=C2=A0=
=3D=C2=A0=7B=0D=0A>=20-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.probe=0D=
=0A>=20+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.probe_new=0D=0A>=20=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=3D=0D=0A>=20(=0D=0A>=20=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0fn=0D=0A>=20=7C=0D=0A>=20-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0&fn=0D=0A=
>=20+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0fn=0D=0A>=20)=0D=0A>=20=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0,=0D=0A>=20=7D;=0D=0A>=20=0D=0A>=20Signed-off-by:=C2=A0Stephen=C2=
=A0Kitt=C2=A0<steve=40sk2.org>=0D=0A=0D=0AAcked-by:=20MyungJoo=20Ham=20<myu=
ngjoo.ham=40samsung.com>=0D=0A=0D=0AChanwoo,=20PTAL.=0D=0A=0D=0ACheers,=0D=
=0AMyungJoo=0D=0A