Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: /AxWeWjioJtLWYEg/JClRN5bcbK+TyQKsZmhFpjW4xNN+m0oKQsW2tFKoAsRpN1VgBQ7r4Y0vQ
 O3n9697JbFUU4LoxSOuFlda+rwYJiirsCA0wWU/H0zUvv0GTfEkic4GhiksTjPLfxs6/oxNmNV
 K4SFxpW4OjnDMz1EcLGOFRdOnNp2lyBFaXh85317c4h8DfiPS3KT3dLT0nmq6d3EeaIjnch+wO
 IqDyayJxp1ctU9RLjwlaLyB5Du22mz+nJSpBP2o/opm8kWZdH3l/YlNxhOTwyvR8K1srhrVC17
 rbs9hgCHHI58HKvxLkcxzs6+
IronPort-SDR: LPrBp4ldaEXVzuTPhMamZRrjT9LkR3co1ce933kOrbnwvxac/lbln4JnGnYTyF+gpzcX/fS2cU
 Lk+rVA11VW7rWnqVS/aLwxsgQqLamY4YVlfH0L6IBFoS3Cu527Bk6bxC7Zt9DP2Q8BVqe3OChe
 jOjyH5vx4EZRi8fBHtggM1fiKHiLoQ6DE6KY3Dar+/URXrNIyJkSMYki7EvWx1TjcX9S8vnUQj
 QKvtzCECXHeEMeb+c+yLxFQUMfn8YJQLoMQreXnBbgFShUhaQVpwT/OmqOqZ0ZKk9Ck4So0xSP
 l+s=
WDCIronportException: Internal
Message-ID: <0e67aa4d-f66e-f392-5950-31b1c90c287b@opensource.wdc.com>
Date:   Thu, 13 Oct 2022 12:54:40 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH 4.19] scsi: sd: Fix 'sdkp' in sd_first_printk
Content-Language: en-US
To:     Li kunyu <kunyu@nfschina.com>, jejb@linux.vnet.ibm.com,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221013023438.3263-1-kunyu@nfschina.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20221013023438.3263-1-kunyu@nfschina.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/10/13 11:34, Li kunyu wrote:
> In the sd_first_printk macro, replace the sdkp parameter with the
> defined sdsk parameter to resolve the compilation error.

Which compilation errors ? None that I can see.
Do you mean "to avoid potential compilation errors" ?

> 
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>  drivers/scsi/sd.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
> index a7d4f50b67d4..e5bdf0a10071 100644
> --- a/drivers/scsi/sd.h
> +++ b/drivers/scsi/sd.h
> @@ -133,7 +133,7 @@ static inline struct scsi_disk *scsi_disk(struct gendisk *disk)
>  
>  #define sd_first_printk(prefix, sdsk, fmt, a...)			\
>  	do {								\
> -		if ((sdkp)->first_scan)					\
> +		if ((sdsk)->first_scan)					\

Instead of changing this one, I would prefer changing sdsk to sdkp in the macro
parameter list. "sdkp" is used everywhere in sd.c. "sdsk" is not used anywhere
so it would be unclear.

>  			sd_printk(prefix, sdsk, fmt, ##a);		\
>  	} while (0)
>  

-- 
Damien Le Moal
Western Digital Research