Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.118.233 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C
From:   Johnny Liu <johnliu@nvidia.com>
To:     <cwchoi00@gmail.com>
CC:     <cw00.choi@samsung.com>, <johnliu@nvidia.com>,
        <kyungmin.park@samsung.com>, <linux-kernel@vger.kernel.org>,
        <linux-pm@vger.kernel.org>, <myungjoo.ham@samsung.com>
Subject: Re: [PATCH v2] devfreq: Support device update function
Date:   Thu, 13 Oct 2022 13:16:27 +0800
Message-ID: <20221013051627.17171-1-johnliu@nvidia.com>
In-Reply-To: <24e701e9-b560-5350-a2f7-89e2a4a1c97a@gmail.com>
References: <24e701e9-b560-5350-a2f7-89e2a4a1c97a@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 05:16:41.1935
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c8e3882-d6b2-4b1d-69b7-08daacda1ce7
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT004.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5969
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for your quick response and detailed comments. I will prepare a new patch
series to include the user of the proposed function. But still I answer your
concerns in the following sections.

On Thu, 13 Oct 2022 04:44, Chanwoo Choi wrote:
> Hi,
>
> Basically, struct devfreq_dev_profile is used to pass the devfreq device data
> from devfreq driver to governor. But, This means that it passes
> the data from governor to devfreq driver reversely?

Yes, it means that governor can pass data to devfreq driver reversely.

> On 22. 10. 3. 15:02, Johnny Liu wrote:
> > To realize interrupt-driven closed-loop governors, governors need to be
>
> Could you explain the detailed means of 'interrupt-driven closed-loop governors'?

For term "interrupt-driven", it means the DFS logic is triggered by interrupts
rather than performing DFS in a polling fashion. This can reduce the CPU load.

For term "closed-loop", it means that there is a target metric the governor will
try to keep it at certain value/level. For example, if the target metric means
device utilization, then the governor should perform DFS so that it will keep
device utilization at certain level specified by the user.

> > able to send data to the underlying devfreq driver to ask for updating
> > the device settings, such as hardware registers for frequency limits,
>
> I think that governor is not able to get the hardware information direclty
> instead of devfreq driver. Usually, the devfreq driver should get the
> h/w info and then passed to governor if required.

Yes, governor should not be able to the HW info directly. From my perspective,
I think governor should be able to pass down hint, such as device utilization
specified by the user in the governor, to the devfreq driver. Then, the
devfreq driver can configure the device accordingly so that interrupts get
triggered when device utilization exceeds or drops by certain amount.

> Lastly, this patch doesn't contain the any use-case of devfreq_update_dev().
> I prefer to post the real use-case of this patch.

I will include the user of it in a new patch series.

> > which are compared against the device frequency to generate interrupts
> >
> > Since governors might export several tunable parameters, users can
> > enforce different policies for the control logics. Under different
> > policies, governors need to send different information to inform the
> > devfreq driver to configure the device accordingly.
> >
> > The introduced update function improves the flexibility of governors
> > and acts as a communication interface between governors and devfreq
> > drivers.
> >
> > Signed-off-by: Johnny Liu <johnliu@nvidia.com>
> > ---
> > v2: Correct the function signature of devfreq_update_dev
> >
> >  drivers/devfreq/governor.h | 8 ++++++++
> >  include/linux/devfreq.h    | 8 ++++++++
> >  2 files changed, 16 insertions(+)
> >
> > diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
> > index 0adfebc0467a..b5781fa549c7 100644
> > --- a/drivers/devfreq/governor.h
> > +++ b/drivers/devfreq/governor.h
> > @@ -124,4 +124,12 @@ static inline int devfreq_update_stats(struct devfreq *df)
> >
> >  	return df->profile->get_dev_status(df->dev.parent, &df->last_status);
> >  }
> > +
> > +static inline int devfreq_update_dev(struct devfreq *df, void *data)
> > +{
> > +	if (!df->profile->update)
> > +		return -EINVAL;
> > +
> > +	return df->profile->update(df->dev.parent, data);
> > +}
> >  #endif /* _GOVERNOR_H */
> > diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
> > index 34aab4dd336c..91648e8f8d76 100644
> > --- a/include/linux/devfreq.h
> > +++ b/include/linux/devfreq.h
> > @@ -92,6 +92,8 @@ struct devfreq_dev_status {
> >   *			devfreq.last_status.
> >   * @get_cur_freq:	The device should provide the current frequency
> >   *			at which it is operating.
> > + * @update:		An optional function to allow governors send data back
> > + *			to the devfreq driver to update the device settings.
>
> IMO, 'update' word is too generic. I think that 'update_device_data' is better
> to improve the readability.

Yes, "update_device_data" has better readability compared to "update".

> >   * @exit:		An optional callback that is called when devfreq
> >   *			is removing the devfreq object due to error or
> >   *			from devfreq_remove_device() call. If the user
> > @@ -114,6 +116,7 @@ struct devfreq_dev_profile {
> >  	int (*get_dev_status)(struct device *dev,
> >  			      struct devfreq_dev_status *stat);
> >  	int (*get_cur_freq)(struct device *dev, unsigned long *freq);
> > +	int (*update)(struct device *dev, void *data);
> >  	void (*exit)(struct device *dev);
> >
> >  	unsigned long *freq_table> @@ -451,6 +454,11 @@ static inline int devfreq_update_stats(struct devfreq *df)
> >  {
> >  	return -EINVAL;
> >  }
> > +
> > +static inline int devfreq_update_dev(struct devfreq *df, void *data)
> > +{
> > +	return -EINVAL;
> > +}
> >  #endif /* CONFIG_PM_DEVFREQ */
> >
> >  #endif /* __LINUX_DEVFREQ_H__ */

--
Best Regards,
Johnny Liu