Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <68f42463-e4b8-d4ce-51c7-3e0e5dc468ec@gmx.de>
Date:   Thu, 13 Oct 2022 08:19:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] fbdev: MIPS supports iomem addresses
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>
Cc:     kernel test robot <lkp@intel.com>, linux-fbdev@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
References: <20221012191838.never.778-kees@kernel.org>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20221012191838.never.778-kees@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 10/12/22 21:18, Kees Cook wrote:
> Add MIPS to fb_* helpers list for iomem addresses. This silences Sparse
> warnings about lacking __iomem address space casts:
>
> drivers/video/fbdev/pvr2fb.c:800:9: sparse: sparse: incorrect type in ar=
gument 1 (different address spaces)
> drivers/video/fbdev/pvr2fb.c:800:9: sparse:     expected void const *
> drivers/video/fbdev/pvr2fb.c:800:9: sparse:     got char [noderef] __iom=
em *screen_base
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/lkml/202210100209.tR2Iqbqk-lkp@intel.com/
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

applied to fbdev git tree.

Thanks!
Helge

> ---
>   include/linux/fb.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index 07fcd0e56682..3822734a38c7 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -555,7 +555,7 @@ static inline struct apertures_struct *alloc_apertur=
es(unsigned int max_num) {
>
>   #elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__) |=
|	\
>   	defined(__hppa__) || defined(__sh__) || defined(__powerpc__) ||	\
> -	defined(__arm__) || defined(__aarch64__)
> +	defined(__arm__) || defined(__aarch64__) || defined(__mips__)
>
>   #define fb_readb __raw_readb
>   #define fb_readw __raw_readw