Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad
Mime-Version: 1.0
Message-Id: <bb9f79d4-82a9-4790-b849-d517333ea2d4@app.fastmail.com>
In-Reply-To: <CAKNVLfaFvge4A8-QUzeq-JManpuYMGvyHXCJi-ew==CWN8-M=A@mail.gmail.com>
References: <20221009181338.2896660-8-lis8215@gmail.com>
 <202210100607.YdxoR0tD-lkp@intel.com>
 <CAKNVLfaFvge4A8-QUzeq-JManpuYMGvyHXCJi-ew==CWN8-M=A@mail.gmail.com>
Date:   Thu, 13 Oct 2022 08:46:39 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Siarhei Volkau" <lis8215@gmail.com>,
        "kernel test robot" <lkp@intel.com>
Cc:     kbuild-all@lists.01.org,
        "Michael Turquette" <mturquette@baylibre.com>,
        "Stephen Boyd" <sboyd@kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzk@kernel.org>,
        "Vinod Koul" <vkoul@kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Paul Cercueil" <paul@crapouillou.net>,
        "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        "Jiri Slaby" <jirislaby@kernel.org>, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        dmaengine@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-mips@vger.kernel.org,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 7/8] serial: 8250/ingenic: Add support for the JZ4750/JZ4755 SoCs
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 13, 2022, at 8:37 AM, Siarhei Volkau wrote:
> =D0=BF=D0=BD, 10 =D0=BE=D0=BA=D1=82. 2022 =D0=B3. =D0=B2 01:29, kernel=
 test robot <lkp@intel.com>:
>> config: ia64-allyesconfig
>> config: arm64-randconfig-r035-20221010
>
>>  > 142  #define CGU_REG_CPCCR   ((void *)CKSEG1ADDR(0x10000000))
>
>> 0-DAY CI Kernel Test Service
>
> I know CKSEG1ADDR is MIPS specific, might be it needed to disable COMP=
ILE_TEST
> on the driver?
> Since early syscon isn't mainlined yet I don't see any other way at th=
e moment.
>
> Any suggestions on that, folks?

This looks like some setup that belongs into the bootloader. If you are
handing over the console from bootloader to kernel, the hardware should
already be in a working state, with no need to touch it during early
boot.

If you are dealing with broken bootloaders that are not under your contr=
ol,
having this code in the architecture specific early boot as a fixup
would be better than putting it into the driver.

      Arnd