Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: fL8o9pz4JoZ+/oeUlviJD8QXgQq51Ef9Tb5kpgxUQ4RhYfSD4Vp7iY1OjYYI7ciCSzBl84+Igf
 I6PWU09CvnQQcFenYyGUHn11wCTsICfu0Q/dcCYN3IWDpEfAK25QlMyNG1cxT6k/aynQ5zewbi
 MeXbNXwdsTWG2pRfElDS5Hd8t7mjqdFzV0WM4WCABRq9xDFsjcKBIN1yfoAoPSpAAkLLIA0VV0
 9mGxDlyM8y+DlLSGHEhktNusX6hbix9TI9fXpFAVwEnJPJ+qGR23Ekb4DRwXBDO+pujDOABB5s
 o544kdZmTIxO3uNNVewOsOqY
IronPort-SDR: /MTyb5SK1Devk8VmExcPkmpNNKI/CY+9Ln4ZwwuwD2SDkvFeyTQsGDtIxUpacAhtvCeQztfGzr
 L/xjLHjcnIxIq/53IL7dvQ777qwejFiSrS06U74RO/bHQBMp52oGgHGEopPVCHJz06mbILQf6d
 uileSyrr4XCIBWjom4Ij8pqbkp/I0Y/6TiDjPtxp49cWwuYsT1memJuTlmNl9U1zoleBP8LW1r
 Jis1QVw/Q8F/C/aLSaXm6CgHv+VGa7H/pHzm4+R9fB1DLKi4xnZaSaKCX2/1jFBeZOglU+PI+E
 MBU=
WDCIronportException: Internal
Message-ID: <8f9304d0-5f28-7378-626b-d734fa7a39a0@opensource.wdc.com>
Date:   Thu, 13 Oct 2022 16:48:30 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: drivers/ata/ahci_st.c:229:34: warning: unused variable
 'st_ahci_match'
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-mips@vger.kernel.org
Cc:     llvm@lists.linux.dev, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org
References: <202210121422.MJsXaw1M-lkp@intel.com>
 <4517c95f-1dad-5a8c-5202-073d0a7eff29@opensource.wdc.com>
 <4429d1ec-579e-4b0d-a8d8-06b9a5877a9c@app.fastmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <4429d1ec-579e-4b0d-a8d8-06b9a5877a9c@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/10/13 16:33, Arnd Bergmann wrote:
> On Thu, Oct 13, 2022, at 8:13 AM, Damien Le Moal wrote:
>> On 10/12/22 15:37, kernel test robot wrote:
> 
>> I am at a loss with this one... There are plenty of patterns similar to
>> drivers/ata/ahci_st.c doing something like:
>>
>> static const struct of_device_id st_ahci_match[] = {
>>
>>         { .compatible = "st,ahci", },
>>
>>         { /* sentinel */ }
>>
>> };
>>
>> MODULE_DEVICE_TABLE(of, st_ahci_match);
>>
>> For instance, in drivers/pwm/pwm-sti.c, we have:
>>
>>
>> And countless others like this for STI and other arch too.
>>
>> So if CONFIG_MODULE is not enabled, how come we are not submerged with
>> warnings about unused variables ? Is mips arch special in this regard ?
>> Or am I missing something ?
> 
> It has nothing to do with MIPS, the problem is
> 
>                 .of_match_table = of_match_ptr(st_ahci_match),
> 
> The 'of_match_ptr()' sets the pointer to NULL when CONFIG_OF is
> disabled, which avoids a build failure when st_ahci_match[]
> itself is in an #ifdef.
> 
> In this driver, there is no #ifdef around st_ahci_match[], so we
> simply want
> 
>                 .of_match_table = st_ahci_match,
> 
> The thing with the MODULE_DEVICE_TABLE() is that it would
> create another reference if CONFIG_MODULE is enabled, but not
> for a built-in driver, so you only get this type of warning
> for randconfig builds that have the driver built-in and OF
> disabled.
> 
> It's a common mistake, and we should probably remove most
> of the of_match_ptr() references as you rarely have drivers
> that optionally use OF support but benefit from compiling
> that support out on kernels without OF.

Got it. Thanks for the info !

Will patch this and check other ata drivers for the same issue.


-- 
Damien Le Moal
Western Digital Research