Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp561818rwi; Thu, 13 Oct 2022 01:56:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5vSIBFiDsFwvLgXWWME90W6QTEzhfbc2CFU03R/c6h71W9+0I01FM1Yk6LsnIWCXqgO8nZ X-Received: by 2002:a17:906:4795:b0:78d:f45c:73d9 with SMTP id cw21-20020a170906479500b0078df45c73d9mr5529684ejc.144.1665651393466; Thu, 13 Oct 2022 01:56:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665651393; cv=none; d=google.com; s=arc-20160816; b=UOatlQTAqvMHWOJEjlf7zter4EDcTDWB0gxxfZBHdhpuZKAYyy3cIuzWwKh50aGzoI uhGQRjvwbawbHOMt9yl9aOxdbQkrhbgrZnFuHy9EPKrfwCxIhRTYypZlYYBDCf+1Z48h 0NPlQdcvzw22/OQEVZUIIrXhSsap/G3FijPW0Sh+xyf+kNkeCvf5tEWAe0f3xxLZsHi/ ajdgENz9pF9cpY7yKbHnGX8CLoxPCBsdkUoQYzfZ4fTdZ1IdnD4GrqgV+DgIP8sLsg40 pp7IFiPy6CwJ8UsHjI/J5P2OQtm+10hfdrKm/f6cuX3M+r6jkBxHv3u1h6BkOStrbSf/ SrEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SP609S9LAwX56cxHH4fg9I3A8/5OOr5dEp1NSW0TrlU=; b=reDPy5sxcli9lJu4qgx8I7YeSBeQawrmjMdbyCpzAzMFpHJh+a5jueCHMvvx/hkdE+ Cndk9zq2ibUvFjd2w1xSP4cpzKRWAEfCVdZKS0h7iQMnARWJhh5VgbDly2RW7ZDIDHrA 1c6VdFMd1JYdoesdD92fbOUdtWpW84QDxJG8c73CjAKXA8Z6pkAe/CYjWQrWWlIajqsT fPzvbKKfM7PGV2uM07+5Jr8vbkOjAcsrkHyNsnHSW8RtiBHEpiLZlTSI5lu1SxDxZqbP gV8DCQbyKC1I6G1TAr5IG7uGKGF/0cvC92A+nDv6j9WbqPvxNWzaKpN9LvCTWeLZbIeL zbvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="e/Z2VOPr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d15-20020a1709061f4f00b0077f4362c957si8486827ejk.702.2022.10.13.01.56.03; Thu, 13 Oct 2022 01:56:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="e/Z2VOPr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbiJMIlP (ORCPT + 99 others); Thu, 13 Oct 2022 04:41:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbiJMIlM (ORCPT ); Thu, 13 Oct 2022 04:41:12 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D5F811C247; Thu, 13 Oct 2022 01:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665650471; x=1697186471; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=w1Sr0LEJVX0x7cu5RWiamo3bb11Ja5HaRisj2wP73S4=; b=e/Z2VOPrbX+l//2Ucab6wgQsrRKfb4d8o2/Fh5DJkcKgUrUPGp7GYo4Q 9IdtxXHCpeXe2dRn7+h9h46TDpvLHFtK6XrQ9cGyj0ICc+UhckgSNn9te 3t3ltW1NPWCghWEaZ5NP8fJ8wq9umwBm9KS5nGsV0KGwPZLlpq2LyRq6c 1ECzA5UZo3jcw/ui1/88uEQqjltWDm1ZzhHkHQww9UMqObZuhNBq3q7X7 B0f6Gax1auIMzJwB5qGTwJHQq0dDm97yTtZJnlfyYi7Rr+kuZQS3SpOLo 3eTNA+Z9uWATkma8yZMOjQ+flABzoEOaevyZ22KT0170+Y2ucdcBZGbhF g==; X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="306085512" X-IronPort-AV: E=Sophos;i="5.95,180,1661842800"; d="scan'208";a="306085512" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 01:41:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="802160583" X-IronPort-AV: E=Sophos;i="5.95,180,1661842800"; d="scan'208";a="802160583" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 13 Oct 2022 01:41:09 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 4AF21FD; Thu, 13 Oct 2022 11:41:30 +0300 (EEST) Date: Thu, 13 Oct 2022 11:41:30 +0300 From: Mika Westerberg To: Mauro Lima Cc: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: intel: Fix the offset to get the 64K erase opcode Message-ID: References: <20221012152135.28353-1-mauro.lima@eclypsium.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221012152135.28353-1-mauro.lima@eclypsium.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 12, 2022 at 12:21:35PM -0300, Mauro Lima wrote: > According to documentation, the 64K erase opcode is located in VSCC > range [16:23] instead of [8:15]. > Use the proper value to shift the mask over the correct range. > > Signed-off-by: Mauro Lima Reviewed-by: Mika Westerberg