Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp581466rwi; Thu, 13 Oct 2022 02:16:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4kqPRW82JV6ixPNeVrAOUI2aYH150bTNhHVcfbkmNc5B19OOcC8TH0EZ80Vdv8G4oHJQmh X-Received: by 2002:a17:907:783:b0:76e:f290:8b5 with SMTP id xd3-20020a170907078300b0076ef29008b5mr26462792ejb.395.1665652603595; Thu, 13 Oct 2022 02:16:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665652603; cv=none; d=google.com; s=arc-20160816; b=jQ+WTgo1mcdteBT7Z+becAd7qHkaLJ63y7jPytEKMcsUoLeFC9EkL+7aiNe7vK17h8 WNMyVw2krTax5wBzuWaQR0U7ZeWZQLgKXGVkDFGroSkkUs1P7bzfeltnQCasI6ZudLzE NeXp6dSFb57m1y5Hq+4I7yNDUVd8DmRCVZ3+bU44pD75fd8NS7G5IHOoCgTludhjO/qI NdKoUurYo4f3mr3X/o/Mqi5x7rhAYRnz/ZyEC9Qsi7xQhHCyjPo+5wxt1079NSrVEKI8 RjaiWfqAf5cQWR/JsgOzUWV7DzTdd+sQpCE+1nbQPKI6N/xX7uA9z0cEfUNkZB6cF8BH F6dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :feedback-id:dkim-signature:dkim-signature; bh=NbLfsfDu1Gtr2c9qmTrYb//pcpOFa59Pn2YWUwdR2PQ=; b=rPiuz+x/54yz3iO4m+id+0OIWCjejdHnK2aaEIkKpj3Ex4xxXy5Y03rR2bY+RLSvzT z4dxD6myuGqgxXuSo4qjINVQFVTStnTGN/qtikXd8C7oo4g1291yRtf8cHDik52uEdpq cVhbS39yOH7wMmJTyIYxUtyjXwBBKCgwk6v4fQFMCuMJkAlNOe2W8/5cBr1OviUXszaj GlsV2fzDAeTD8p052xHEDAiCrHYHDK/Ji3CfUbCmIk1Wklqahceip7Uk6eoEYZQc/1fs sTFSkCrt5IoDn5PkGNtr03B6Y1jEbZXpPmlHGDGMtwbPqSYSk6jaRuOgg3NvjU1NfvEu fgzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b=vbtCpBwB; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=TPWfBqKr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa10-20020a170907868a00b0078e1a6fbe15si112664ejc.690.2022.10.13.02.16.17; Thu, 13 Oct 2022 02:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b=vbtCpBwB; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=TPWfBqKr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbiJMJNb (ORCPT + 99 others); Thu, 13 Oct 2022 05:13:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbiJMJNT (ORCPT ); Thu, 13 Oct 2022 05:13:19 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60532107CC9; Thu, 13 Oct 2022 02:13:18 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C860C5C00D5; Thu, 13 Oct 2022 05:13:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 13 Oct 2022 05:13:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665652397; x= 1665738797; bh=NbLfsfDu1Gtr2c9qmTrYb//pcpOFa59Pn2YWUwdR2PQ=; b=v btCpBwB/dRvHJNh0uI58CDkNB68elf0mXaDTcTgRndoUTf0zCIQeMDtwFrxM8um+ XwJWnEdsiC5nq5CzPoHkfY6TVE8y1h0mPbCrY7V+JuH9vFurD0A2K4nzhVt0+vhX waJUsEwzIlRyZVFXyDSTAIcy/3ONewTOagiq8L5ynmvLk3mrTZwlM/eMs7Ah1zSn DJxT7L0b2znlVIRcOmwkOHcmIhwKgWOWo3OZgSL61Q4qMb2qdKmLb8IAE3axLnR6 Q73dP2H2CZsXliafRb+KFYNDx6NQhifboMeKC6Ium3JJ6hltyb8kOIb5wdkSO7KQ imrfWCd8dfcMwFEuvFhSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665652397; x= 1665738797; bh=NbLfsfDu1Gtr2c9qmTrYb//pcpOFa59Pn2YWUwdR2PQ=; b=T PWfBqKrIsFE6oum+0YE5rNlNG508+cLK1ooGcDBMdHx7E5NZZmRoYErukFlsi4QP 3xgi1gKoZJR0hcplg0V7HkFSwer8XCiQuMVZjvRw1r5sd3cLExrbQgYoZ9K37y4+ leWarvxWLgtofU0W0xmwzH04Oz+XzjsVgjrASb1R10pVCMwUtsDCoh7IzjYfKpoP H+tBLQjw91xozW5dm01eheXGZtvzVdMORMByvGGi75gECCdgwL2WcNFGPAwXv7pF 1Tqa0ZXQLRqotmapTogf0Xosi7AA8qjAZkvdrTJTOQ+oLoWcu08IuvcQDFsNBEex 4jhJ+o9VfPdbUbG5cjyeA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeektddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Oct 2022 05:13:17 -0400 (EDT) From: Maxime Ripard Date: Thu, 13 Oct 2022 11:13:10 +0200 Subject: [PATCH v3 3/7] firmware: raspberrypi: Provide a helper to query a clock max rate MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20220815-rpi-fix-4k-60-v3-3-fc56729d11fe@cerno.tech> References: <20220815-rpi-fix-4k-60-v3-0-fc56729d11fe@cerno.tech> In-Reply-To: <20220815-rpi-fix-4k-60-v3-0-fc56729d11fe@cerno.tech> To: Florian Fainelli , Michael Turquette , Emma Anholt , Stephen Boyd , Ray Jui , Scott Branden , Broadcom internal kernel review list , Daniel Vetter , David Airlie , Maxime Ripard Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Maxime Ripard , Stefan Wahren , linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Dom Cobley , dri-devel@lists.freedesktop.org X-Mailer: b4 0.11.0-dev-7da52 X-Developer-Signature: v=1; a=openpgp-sha256; l=3367; i=maxime@cerno.tech; h=from:subject:message-id; bh=RlOL1ZTsE2adkZajmlAYwbEWoCI8gC05XMJ1fjN2UAo=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMnu15ZMmB1f+OGOaJ3DD/NDG62OXJho9PnTrrmnjBaasMqU TIxY3FHKwiDGxSArpsgSI2y+JO7UrNedbHzzYOawMoEMYeDiFICJ6D1lZFi6+Gf0ygvPX4Wtlln+eY Lnx/9bRT19U4piEqt+qqocfsnPyNDg1Ovz5+aUr6K1EVMSn5ezSLVI+Bvv+bH/tlxyVIeSNycA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The firmware allows to query for its clocks the operating range of a given clock. We'll need this for some drivers (KMS, in particular) to infer the state of some configuration options, so let's create a function to do so. Acked-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/firmware/raspberrypi.c | 20 ++++++++++++++++++++ include/soc/bcm2835/raspberrypi-firmware.h | 26 ++++++++++++++++++++++++++ 2 files changed, 46 insertions(+) diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c index b916e1e171f8..1353ec2f9b53 100644 --- a/drivers/firmware/raspberrypi.c +++ b/drivers/firmware/raspberrypi.c @@ -228,6 +228,26 @@ static void rpi_register_clk_driver(struct device *dev) -1, NULL, 0); } +unsigned int rpi_firmware_clk_get_max_rate(struct rpi_firmware *fw, unsigned int id) +{ + struct rpi_firmware_clk_rate_request msg = + RPI_FIRMWARE_CLK_RATE_REQUEST(id); + int ret; + + ret = rpi_firmware_property(fw, RPI_FIRMWARE_GET_MAX_CLOCK_RATE, + &msg, sizeof(msg)); + if (ret) + /* + * If our firmware doesn't support that operation, or fails, we + * assume the maximum clock rate is absolute maximum we can + * store over our type. + */ + return UINT_MAX; + + return le32_to_cpu(msg.rate); +} +EXPORT_SYMBOL_GPL(rpi_firmware_clk_get_max_rate); + static void rpi_firmware_delete(struct kref *kref) { struct rpi_firmware *fw = container_of(kref, struct rpi_firmware, diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h index 74c7bcc1ac2a..10248c370229 100644 --- a/include/soc/bcm2835/raspberrypi-firmware.h +++ b/include/soc/bcm2835/raspberrypi-firmware.h @@ -154,12 +154,32 @@ enum rpi_firmware_clk_id { RPI_FIRMWARE_NUM_CLK_ID, }; +/** + * struct rpi_firmware_clk_rate_request - Firmware Request for a rate + * @id: ID of the clock being queried + * @rate: Rate in Hertz. Set by the firmware. + * + * Used by @RPI_FIRMWARE_GET_CLOCK_RATE, @RPI_FIRMWARE_GET_CLOCK_MEASURED, + * @RPI_FIRMWARE_GET_MAX_CLOCK_RATE and @RPI_FIRMWARE_GET_MIN_CLOCK_RATE. + */ +struct rpi_firmware_clk_rate_request { + __le32 id; + __le32 rate; +} __packed; + +#define RPI_FIRMWARE_CLK_RATE_REQUEST(_id) \ + { \ + .id = _id, \ + } + #if IS_ENABLED(CONFIG_RASPBERRYPI_FIRMWARE) int rpi_firmware_property(struct rpi_firmware *fw, u32 tag, void *data, size_t len); int rpi_firmware_property_list(struct rpi_firmware *fw, void *data, size_t tag_size); void rpi_firmware_put(struct rpi_firmware *fw); +unsigned int rpi_firmware_clk_get_max_rate(struct rpi_firmware *fw, + unsigned int id); struct device_node *rpi_firmware_find_node(void); struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node); struct rpi_firmware *devm_rpi_firmware_get(struct device *dev, @@ -179,6 +199,12 @@ static inline int rpi_firmware_property_list(struct rpi_firmware *fw, static inline void rpi_firmware_put(struct rpi_firmware *fw) { } +static inline unsigned int rpi_firmware_clk_get_max_rate(struct rpi_firmware *fw, + unsigned int id) +{ + return UINT_MAX; +} + static inline struct device_node *rpi_firmware_find_node(void) { return NULL; -- b4 0.11.0-dev-7da52