Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Oct 2022 15:41:15 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     "Hans J. Schultz" <netdev@kapio-technology.com>
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yuwei Wang <wangyuweihx@gmail.com>,
        Petr Machata <petrm@nvidia.com>,
        Florent Fourcot <florent.fourcot@wifirst.fr>,
        Hans Schultz <schultz.hans@gmail.com>,
        Joachim Wiberg <troglobit@gmail.com>,
        Amit Cohen <amcohen@nvidia.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v7 net-next 1/9] net: bridge: add locked entry fdb flag
 to extend locked port feature
Message-ID: <Y0gHa99Z70TkKtR5@shredder>
References: <20221009174052.1927483-1-netdev@kapio-technology.com>
 <20221009174052.1927483-2-netdev@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221009174052.1927483-2-netdev@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KdhLC7vUT5YkTUGSXcVIb8E29Q8EaAh1XEQEVLmY+PGwbz25jqNQisGwPioZ?=
 =?us-ascii?Q?aQsEK1/6AM3gMGqAfRdLCxlJ0wD44AkTet8nn1JTmN3BQWq9dRnvjhbxgUQ7?=
 =?us-ascii?Q?0CfeNmDDJRsWp3u6lyskUsaQ0vDEmddsKOaE0ZfQdI6tCDL9VFfATbLq/E2g?=
 =?us-ascii?Q?yrJh3hPjKbXg55laMwQv8mC5WWLTt8DgDmFqq91luCencGFlIY9Dd8PfJo+u?=
 =?us-ascii?Q?1TmPs/V6omoHj0NhEAIIYuPZNN6RCc5+4sTFBxZsssucu04NFpapr6cZl7F6?=
 =?us-ascii?Q?1RYMXdNo0kMiWHQr4cUzs69zQGjhf+DQs/SBxdb3K5tO1LFZ3uO0gPdG3BoG?=
 =?us-ascii?Q?UFWQdSCHWurZYRFsWwz/G6cWJZIGy1t6YEI0L6y6UF1RWiRmXC8bOx7LKMNg?=
 =?us-ascii?Q?hWSzLh17BAAmzJEeFyDLpNeZaIO2cfqS3rjJHT806J+Qw8iVuo/VRj3s5oNw?=
 =?us-ascii?Q?KajHVBSO++ZvheG2tMHksNPS4cxa3ZXdC/rkthyiwG1n9WqdtHmYFr1i99YN?=
 =?us-ascii?Q?lBbH1ZS34+Pvrl+A+hluLLSA6Ze8KUMdS8WE+gXKbxiGCSE0X2gmi064V/97?=
 =?us-ascii?Q?aqwyUg7VW/kKxCA9rv0ZO9JKwi1JFwzxTGc6abCW5N4q4SF+th3qJuYiYUbf?=
 =?us-ascii?Q?JEgQxJK0OVGvhBewyv4cu4y1NNMvLvZOs8eqdMRJkMuoSJS+n4vV1Z+MKaDI?=
 =?us-ascii?Q?6wkTGRZEuqsPMSsM60kmlRUrmA2jsfJrhnjElzdcW68gfHszdx/qFhNdP/HN?=
 =?us-ascii?Q?sS8Ve8VYXfKbfzsPU6kydLlAJOkUbaaKf3HK/u1dkK+Ry1WwVG46YdYEBbhS?=
 =?us-ascii?Q?jh/4TzMGD3ouUkyazmQJ2ibFIWljvOoL2KLYbmFnCKZjJRpgF2TGUHCQRrYd?=
 =?us-ascii?Q?X5V/m0itWrinuo/C4yk0nHuvPA3Nk3Y+Og83BLMjEvswpbIgja/oPLQd5LYj?=
 =?us-ascii?Q?Kf8h/unBH+zZtPOUI1PPR3HLo3moHDJUFoOzgCPOFNKP+gx8PEb2ZAU2chOQ?=
 =?us-ascii?Q?ZoQdF9FJ/KXgiFDrwfAQH9Io/4hBNna/GgmDvQHogzKNb6CHCN+BmEoFqf14?=
 =?us-ascii?Q?umqtHFL7VITa/McW9IX8PYqn5gTGR8CrMp2r5K7tHZDcXW/ePHTbRVrB50l2?=
 =?us-ascii?Q?oAe+aYLEifAzVZ8W8I6RMytgQ4pbSizQ4YwdpeYCm2KQGfiEF0eNxVcazQKq?=
 =?us-ascii?Q?xlu5lE3gw2BwUm/l/Ebc/VxtKvkYFpBT8WoJIKpGcRy1+Tgg/2CUxIH7YhND?=
 =?us-ascii?Q?CTIQzM2lJi8ox2hBLsGhyZD/AllJ6h4oQE2thmGCDJEweI8rzH4lJ9PSsuM7?=
 =?us-ascii?Q?jmlBCNwBYkv5q7Qx19VooIdOYG5XbRl3wmqtOCMeQjsgSA5Bi/hVp65CL1x0?=
 =?us-ascii?Q?+MgL0nysyk4T9GEuYAXwCN1/9yMjqA1DmA2WHM+y0VcxytPnfERKN3+wBtl3?=
 =?us-ascii?Q?9TIOYPt2/x982BhnrtAIOFsw//H6H9ltj5r2mMZCntPOSziMiEgfToRu8dfv?=
 =?us-ascii?Q?ZPht14TD84pEQuHyBysKjFDcV5sxD0pFH1LfAZ1CLm9OooBg3iGdkETDDsXn?=
 =?us-ascii?Q?cm+WM/jCuYD6EdJRRuHsEfQkTkdG9J2s2hPTDewj?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d642b567-d51b-4d6b-e266-08daad183b80
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 12:41:21.9700
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o48crjiwJYsgm3ZJhnXLaidzaNdMkn1pbwXbiodxJtAo0pNjCq4Nn8TWTgv/Jwo3ZanLIORqFwVaxp48FOjuyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6550
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 09, 2022 at 07:40:44PM +0200, Hans J. Schultz wrote:
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 74864dc46a7e..8008ceb45605 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -4035,6 +4035,7 @@ int ndo_dflt_fdb_add(struct ndmsg *ndm,
>  		     const unsigned char *addr, u16 vid,
>  		     u16 flags)
>  {
> +	__u32 ext_flags = 0;
>  	int err = -EINVAL;
>  
>  	/* If aging addresses are supported device will need to
> @@ -4050,6 +4051,14 @@ int ndo_dflt_fdb_add(struct ndmsg *ndm,
>  		return err;
>  	}
>  
> +	if (tb[NDA_FLAGS_EXT])
> +		ext_flags = nla_get_u32(tb[NDA_FLAGS_EXT]);
> +
> +	if (ext_flags & NTF_EXT_LOCKED) {
> +		netdev_info(dev, "invalid flags given to default FDB implementation\n");
> +		return err;
> +	}

I'm not sure it makes sense to deny specific flags in this case. It
might be better to just error out if NDA_FLAGS_EXT was specified.

> +
>  	if (is_unicast_ether_addr(addr) || is_link_local_ether_addr(addr))
>  		err = dev_uc_add_excl(dev, addr);
>  	else if (is_multicast_ether_addr(addr))
> -- 
> 2.34.1
>