Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     "S.J. Wang" <shengjiu.wang@nxp.com>,
        "andersson@kernel.org" <andersson@kernel.org>,
        "mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
        "arnaud.pouliquen@foss.st.com" <arnaud.pouliquen@foss.st.com>
CC:     "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "shengjiu.wang@gmail.com" <shengjiu.wang@gmail.com>
Subject: RE: [PATCH] remoteproc: core: Auto select rproc-virtio device id
Thread-Topic: [PATCH] remoteproc: core: Auto select rproc-virtio device id
Thread-Index: AQHY3q9adSuOrIoTmESz5WeUdSOak64MRjFQ
Date:   Thu, 13 Oct 2022 12:47:43 +0000
Message-ID: <DU0PR04MB941728B0F306EE5FA35738B388259@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <1665628087-20829-1-git-send-email-shengjiu.wang@nxp.com>
In-Reply-To: <1665628087-20829-1-git-send-email-shengjiu.wang@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VrQRO7CFZysaN2RhBfSZZXc/KoqwFqvDyHcSqsoRzYACGHJ62yQxaAq0yPZV?=
 =?us-ascii?Q?+jwQGNsZzpj6ATXC2I3C4Wk8cesscTCyVFqLJ1MKAdaR8DkS4Fr6tlyrM+m3?=
 =?us-ascii?Q?ygvHQUmSLQ7IH37C1E9/XF9zN5uIBx1hh74DPB3ZzofuY9fij76p3M7a0c5o?=
 =?us-ascii?Q?MFzy4yGHcbvLnX9sEuNw6Jt2FmJd77UnJzjsdGs6jdwq0c6PRqHUiLkR45vk?=
 =?us-ascii?Q?rBB6CiA6u5Nm7wz+4kma0PMym9ChXyxiUqGYNTnFfPvYvXzSRQTf4FwzJEqa?=
 =?us-ascii?Q?qUAZn5NyiVd+4pWW4/f+iKY801+Jw/m2Hv6WXhnyBDhxnRPKAUKC2A/mv9BW?=
 =?us-ascii?Q?UO8XaQYb2alxEXygv9sL9l19tPxqJKICW8uRsoO2lj5VBjIV0Fb774Z33gAq?=
 =?us-ascii?Q?DQ1jX7hbyHtDWpj//2eJ0iv/SQnn0hLs1KIGsULsBjJRZNDvpluhp4O+G64Y?=
 =?us-ascii?Q?AUfZVNAFspQSTN+Uf65y8w22vCTi8+Yf3D9HqG+LA9/iVSJrkF9cwMm8coJK?=
 =?us-ascii?Q?/L6f6UY2Uv7YVGeVRSt8UXMGodioN+MMY1Y0tCrscmMCxlX02wZFL9REy3ak?=
 =?us-ascii?Q?kAKBB4uDBVzc5+UT2QZYwdMA7mgLWdswz3avBLcQlYXPmE5Ed1ar44tryZok?=
 =?us-ascii?Q?UxzjJy4pvMRF9rLxREVl8xw73DbY95Fx6eXrpFe2fU6so8cr2c5xfxwoARIg?=
 =?us-ascii?Q?iz5Ob733Bojb7lKToJW39esAo13lsQ044LfVrIPS/19igGjCHkLiQRoDv3El?=
 =?us-ascii?Q?sXuPxOW5hb0cO3kiV+T1CBrIXGMWmYLkUVKMQuiBYbJ5L4bnRPXFw1EVcl+C?=
 =?us-ascii?Q?x2LNGz31vjyK06T+JWoNufuLtXefVaUDm3LTZz4/U2MpeCEYaoPi3zFm+I8v?=
 =?us-ascii?Q?jRGmIGQeF9I691ctKMF5mxzs4eELttHqwjABBYJOeSWoM0tkg7qceNAQPq1d?=
 =?us-ascii?Q?YFODZ22ecOuJgG8/T0A02qjK/veB8yYol5QcWNeuk89oWPhPyvrnAXGVNrWL?=
 =?us-ascii?Q?fZWGGAVp6JIWNU5Djd0Ypg/2hlr0oXuFdGZ3Ka0396Vu+L0jETS+mE5qc3Ds?=
 =?us-ascii?Q?srC8qacIWtBlnUYOhGM1745ZukoxLc9NI0iLeIL0UbqLpgjAsE7rlxMJP9Tu?=
 =?us-ascii?Q?N+QKatsiwdEagboaHkbUT78WumxcJTF73Z3B/jIAqZnC4WP0AKvQAv0hz5LN?=
 =?us-ascii?Q?mXNcQO4fj5MzGBK7iM9+o9HjFTnsHjesb0ZDSbizJp6KKszYbu0bRaoecLzs?=
 =?us-ascii?Q?sWT37okxEhHMyPT5QUmZPC5VefvBb15pi8uA5Dl/Kc/VOhzF/CNsR0Gzx1an?=
 =?us-ascii?Q?98t4G8v/w0ak05kTCcBxNDeb2yCq5WPH0em93gcRxCs4YcQVDmqAeE6DAYvp?=
 =?us-ascii?Q?d8+lLCVfKKCnvgMTzqN3tt4p+VENM4n43zTaNq8sQj2W6/glRXCDOeY7KTyF?=
 =?us-ascii?Q?Dlw3xP0ymwWyMR3b9Q8U8V56pdixuvCiLlBi5A7NfKAu2d68ROEOZwXAldTA?=
 =?us-ascii?Q?pgS54PqO2X2gIHEj+ym1JoszqBt8MQH+jwEru6HiBQmMXHPArw2/1KllbMbG?=
 =?us-ascii?Q?tfC+jn+yy2/HsfVKX/1h2636pGnbUc4g09ASdImN?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: adba5df8-ad85-4f21-a4a1-08daad191f02
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 12:47:43.1782
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bREGhgXdvkyYqt3xstjobNqUXLnJSQ7biAN+ACOcgLZy7gc5iHOjlbS1tPqCvsGZvMWXkCmODMSP9unIc36VOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9212
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] remoteproc: core: Auto select rproc-virtio device id
>=20
> With multiple remoteproc device, there will below error:
>=20
> sysfs: cannot create duplicate filename '/bus/platform/devices/rproc-
> virtio.0'
>=20
> The rvdev_data.index is duplicate, that cause issue, so need to use the
> PLATFORM_DEVID_AUTO instead.
>=20
> Fixes: 1d7b61c06dc3 ("remoteproc: virtio: Create platform device for the
> remoteproc_virtio")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>

Met same issue with on i.MX8QM-MEK dual CM4 case, and I tested same
approach as you did.

Tested-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/remoteproc/remoteproc_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> index 8768cb64f560..03a26498e879 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -509,7 +509,7 @@ static int rproc_handle_vdev(struct rproc *rproc,
> void *ptr,
>  	rvdev_data.rsc_offset =3D offset;
>  	rvdev_data.rsc =3D rsc;
>=20
> -	pdev =3D platform_device_register_data(dev, "rproc-virtio",
> rvdev_data.index, &rvdev_data,
> +	pdev =3D platform_device_register_data(dev, "rproc-virtio",
> +PLATFORM_DEVID_AUTO, &rvdev_data,
>  					     sizeof(rvdev_data));
>  	if (IS_ERR(pdev)) {
>  		dev_err(dev, "failed to create rproc-virtio device\n");
> --
> 2.34.1