Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <84dee7a6-f8f7-75ee-b0a2-5c1516e7c0fd@linaro.org>
Date:   Thu, 13 Oct 2022 08:28:37 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 2/3] arm64: dts: qcom: msm8996: align TLMM pin
 configuration with DT schema
Content-Language: en-US
To:     konrad.dybcio@somainline.org
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221012151545.39061-1-krzysztof.kozlowski@linaro.org>
 <20221012151545.39061-2-krzysztof.kozlowski@linaro.org>
 <99ae66c725776f110272cdc2359241f7@somainline.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <99ae66c725776f110272cdc2359241f7@somainline.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/10/2022 14:32, konrad.dybcio@somainline.org wrote:
> On 2022-10-12 17:15, Krzysztof Kozlowski wrote:
>> DT schema expects TLMM pin configuration nodes to be named with
>> '-state' suffix and their optional children with '-pins' suffix.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/apq8096-db820c.dts   |  96 ++++------
>>  arch/arm64/boot/dts/qcom/apq8096-ifc6640.dts  |  68 ++------
>>  .../dts/qcom/msm8996-sony-xperia-tone.dtsi    |  26 +--
>>  .../boot/dts/qcom/msm8996-xiaomi-common.dtsi  |  10 +-
>>  .../boot/dts/qcom/msm8996-xiaomi-gemini.dts   |   8 +-
>>  .../boot/dts/qcom/msm8996-xiaomi-natrium.dts  |   4 +-
>>  .../boot/dts/qcom/msm8996-xiaomi-scorpio.dts  |   8 +-
>>  arch/arm64/boot/dts/qcom/msm8996.dtsi         | 164 +++++++++---------
>>  8 files changed, 153 insertions(+), 231 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> index 5cdc7ac1a9c0..a3d1ff1aba8f 100644
>> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> @@ -422,82 +422,46 @@ &tlmm {
>>  		"NC", /* GPIO_148 */
>>  		"NC"; /* GPIO_149 */
>>
>> -	sdc2_cd_on: sdc2_cd_on {
>> -		mux {
>> -			pins = "gpio38";
>> -			function = "gpio";
>> -		};
>> -
>> -		config {
>> -			pins = "gpio38";
>> -			bias-pull-up;		/* pull up */
>> -			drive-strength = <16>;	/* 16 MA */
>> -		};
>> +	sdc2_cd_on: sdc2-cd-on-state {
>> +		pins = "gpio38";
>> +		function = "gpio";
>> +		bias-pull-up;
>> +		drive-strength = <16>;
> How about drive-strength before bias- properties? I think most DTs have 
> it like that.

Sure, I can move it.

> 
> Other than that,
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>


Best regards,
Krzysztof