Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <994c01b3-253c-9cc1-1a15-4f17226c2f7d@quicinc.com>
Date:   Thu, 13 Oct 2022 18:12:08 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH] remoteproc: core: avoid duplicated rproc-virtio.[x]
 device
Content-Language: en-US
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, <andersson@kernel.org>,
        <mathieu.poirier@linaro.org>, <arnaud.pouliquen@foss.st.com>,
        <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Peng Fan <peng.fan@nxp.com>
References: <20221013123214.750320-1-peng.fan@oss.nxp.com>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20221013123214.750320-1-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 10/13/2022 6:02 PM, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> When there are multiple remoteproc cores(i.MX8QM has dual CM4), there
> will be duplicated platform device created. When 1st CM4 rproc got
> probed, rproc-virtio.0 was registered. Then 2nd CM4 rproc continue
> register rproc-virtio.o will report failure.
> 
> So use PLATFORM_DEVID_AUTO here. Then the kernel log will has such:
> rproc-virtio rproc-virtio.1.auto: registered virtio0 (type 7)
> 
> Fixes: 1d7b61c06dc3 ("remoteproc: virtio: Create platform device for the remoteproc_virtio")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> V1:
>    I think this issue will happen when more than one rproc, saying CM4 + DSP,
> or CM4 + CM4.
>    I thought to add a index to rproc, then use
>    'rproc->index * rvdev_data.index' as the id, but seems a bit complicated
>    compared with use PLATFORM_DEVID_AUTO.
> 
> 
>   drivers/remoteproc/remoteproc_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 8768cb64f560..03a26498e879 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -509,7 +509,7 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
>   	rvdev_data.rsc_offset = offset;
>   	rvdev_data.rsc = rsc;
>   
> -	pdev = platform_device_register_data(dev, "rproc-virtio", rvdev_data.index, &rvdev_data,
> +	pdev = platform_device_register_data(dev, "rproc-virtio", PLATFORM_DEVID_AUTO, &rvdev_data,
>   					     sizeof(rvdev_data));
>   	if (IS_ERR(pdev)) {
>   		dev_err(dev, "failed to create rproc-virtio device\n");


Looks to be same as

https://lore.kernel.org/lkml/1665628087-20829-1-git-send-email-shengjiu.wang@nxp.com/

-Mukesh