Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mukesh Ojha <quic_mojha@quicinc.com>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        "andersson@kernel.org" <andersson@kernel.org>,
        "mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
        "arnaud.pouliquen@foss.st.com" <arnaud.pouliquen@foss.st.com>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] remoteproc: core: avoid duplicated rproc-virtio.[x]
 device
Thread-Topic: [PATCH] remoteproc: core: avoid duplicated rproc-virtio.[x]
 device
Thread-Index: AQHY3v+dFOn8qSfXn0WnZQ84dnwr864MRGoAgAAAPRA=
Date:   Thu, 13 Oct 2022 12:44:28 +0000
Message-ID: <DU0PR04MB941741503263A70DA7606DED88259@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20221013123214.750320-1-peng.fan@oss.nxp.com>
 <994c01b3-253c-9cc1-1a15-4f17226c2f7d@quicinc.com>
In-Reply-To: <994c01b3-253c-9cc1-1a15-4f17226c2f7d@quicinc.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c+BfbJ9+txQvo8fekNuzz1j87Q+Ag5sY1FsMZGICHz6g2XOD6aPtqNt/LCxC?=
 =?us-ascii?Q?O+oPKTStODukXoYFvNWjN0ab2Ya9gqmu6Q9cnGkOlUhftvgXYShJRNZbgAaD?=
 =?us-ascii?Q?tAGlbCFWn8LwJ3/+ftCltseP7P/IBWTtu0MzTVUYWCfY86a4toKHDY67/km+?=
 =?us-ascii?Q?dENBb9oNPvIH08VZMJqiju4T1AYnmj/Wkz2iUz6co3kvetgADbpm4EvHPeGG?=
 =?us-ascii?Q?pYp1XIrD923Bj59S6eUOVjJXn6otYkdQ28x/xjw+pKGsuMybN93NRVsyztLr?=
 =?us-ascii?Q?EtNjKWz1zqWbRRZMqleatLF19QLyaoaKEHOwGjvavQs41P0KwdLV86LAySNj?=
 =?us-ascii?Q?D0os8s6jIXdWK8fJ6M5XZHfxyNZAVxJ7A0I8NHOLRocG0ub5Yzr8lmFgcMSi?=
 =?us-ascii?Q?QuQOAYsIOOeqyiS9cYdiIZ3U9LRMxARcRZgEAICFS98Xu0SoC672WVz6qdOC?=
 =?us-ascii?Q?xeLonBBBXW29dIqtLCcQEv8x3FoDWyNSe8SmHU/6Moyey35Zyy1HUcyGkWM1?=
 =?us-ascii?Q?TZEwJkqbBtqPef8uo7VOXXuUYXYMUZ4UbeLxBq+YhGjc8ilAGsLGc+1spT76?=
 =?us-ascii?Q?74S4DsdskNAjQBY4mkD1tC7hEPXzcqDC062E0dv4MUGL8uWaxG9bsihM8dBv?=
 =?us-ascii?Q?e5bBJXlyHk1QWfnTyzio7AQ4R5pJhDyYzSwQZKYXIW0tIRJYb9x3djzsYLqu?=
 =?us-ascii?Q?AVZZ3/zh77hjoVTl+lyOq5C/IOHK/WN6diEW8ACmPCFukrXpcxF6tMSIJ6ED?=
 =?us-ascii?Q?rTd0Lk4tKAK950UUqe45RaRhiZc4X4EAsr3gFIbMKLfMn63EM2HVYai3M9T4?=
 =?us-ascii?Q?UVZQUDCKZCqtPkQQs8xZ+azLsqdfaBNpdlKejAePHr+9iWP7cdhC+haNxM5E?=
 =?us-ascii?Q?R8p5yqtLmrcjJAvWWH2lQ8qAe+90tQNtzod6b4IAzLWky6SYcgXVVYr55FMh?=
 =?us-ascii?Q?LzAEXqOl33sMhh/ianuLOVVqtiEtgiB7cz5UoeLvtu8zzOHnTYsQvPaRmAkF?=
 =?us-ascii?Q?844Im4rImTLO4t1jHh8W01bjm/umd+XpNu80N/1z7mhVCqJlbmOmcIA1qY3I?=
 =?us-ascii?Q?jgI/YEcTiMl9dcunT3ITQProvoV9p8HaRZIE98GqG0kAC3jk3jySS7tOfVS7?=
 =?us-ascii?Q?mbjUGYLk/F1ZMXCwrM6qr0GNYrLKpKPo+moYD4J1Qo0/fUtv7YM1sDRhyn0g?=
 =?us-ascii?Q?UHwQWhCyVR1ASM8GEVBAR0cFDa+QglxjceoxspFjkIb9wW0EsbV4FjG1rykI?=
 =?us-ascii?Q?yXlPv2nOxjgnGIokA5/QiDrWp2JHzj/OKzognCW25QDdHsJ8FxxhSE3J/IbH?=
 =?us-ascii?Q?q9q8mGToBjlFgB9NE4KwRRoBQhQaLCfoGr4s9ywrUXejNP31eLo30G0RNNuY?=
 =?us-ascii?Q?ATNIHSONZQNuoakZI/LPYi0gpdhcwg3vy34r5NXywsRG+LGKTeVymH611i0S?=
 =?us-ascii?Q?17cnIdnUut8rQEEs4B/ns7Mxr6LiAirDknmbbMs6thLMe3m0Eao4QaUiWrRC?=
 =?us-ascii?Q?3AKf8yyYG1vMcsobnEic8DJNrKEzQDclDJUoFsSVtN8F7YX1Y5qfijuaZPve?=
 =?us-ascii?Q?paubvAlEJ6Q6Po7G00E=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbe23fb5-9866-4d54-f518-08daad18aab9
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 12:44:28.1324
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Rr9JdtsLOOaD3iAsCLfxxDWY/k9kCNKE2thiqjUNMs8elJKptxU60bebliKcWKq/F95bpByFk+Jis92F8b0RyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7157
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS,
        T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH] remoteproc: core: avoid duplicated rproc-virtio.[x]
> device
>=20
> Hi,
>=20
> On 10/13/2022 6:02 PM, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > When there are multiple remoteproc cores(i.MX8QM has dual CM4), there
> > will be duplicated platform device created. When 1st CM4 rproc got
> > probed, rproc-virtio.0 was registered. Then 2nd CM4 rproc continue
> > register rproc-virtio.o will report failure.
> >
> > So use PLATFORM_DEVID_AUTO here. Then the kernel log will has such:
> > rproc-virtio rproc-virtio.1.auto: registered virtio0 (type 7)
> >
> > Fixes: 1d7b61c06dc3 ("remoteproc: virtio: Create platform device for
> > the remoteproc_virtio")
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > V1:
> >    I think this issue will happen when more than one rproc, saying CM4
> > + DSP, or CM4 + CM4.
> >    I thought to add a index to rproc, then use
> >    'rproc->index * rvdev_data.index' as the id, but seems a bit complic=
ated
> >    compared with use PLATFORM_DEVID_AUTO.
> >
> >
> >   drivers/remoteproc/remoteproc_core.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/remoteproc_core.c
> > b/drivers/remoteproc/remoteproc_core.c
> > index 8768cb64f560..03a26498e879 100644
> > --- a/drivers/remoteproc/remoteproc_core.c
> > +++ b/drivers/remoteproc/remoteproc_core.c
> > @@ -509,7 +509,7 @@ static int rproc_handle_vdev(struct rproc *rproc,
> void *ptr,
> >   	rvdev_data.rsc_offset =3D offset;
> >   	rvdev_data.rsc =3D rsc;
> >
> > -	pdev =3D platform_device_register_data(dev, "rproc-virtio",
> rvdev_data.index, &rvdev_data,
> > +	pdev =3D platform_device_register_data(dev, "rproc-virtio",
> > +PLATFORM_DEVID_AUTO, &rvdev_data,
> >   					     sizeof(rvdev_data));
> >   	if (IS_ERR(pdev)) {
> >   		dev_err(dev, "failed to create rproc-virtio device\n");
>=20
>=20
> Looks to be same as
>=20
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flore.
> kernel.org%2Flkml%2F1665628087-20829-1-git-send-email-
> shengjiu.wang%40nxp.com%2F&amp;data=3D05%7C01%7Cpeng.fan%40nxp.c
> om%7C668b13ed67d24714d51008daad185d69%7C686ea1d3bc2b4c6fa92cd
> 99c5c301635%7C0%7C0%7C638012617398936051%7CUnknown%7CTWFpb
> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
> 6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3DBlv30z3AYk6v3GTS4aEizM62v2
> zrTmK1rDFAdlxagB8%3D&amp;reserved=3D0

Ohh! Duplicated effort, I should check list before working on this (:

Thanks,
Peng.
>=20
> -Mukesh