Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Oct 2022 21:09:55 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC:     Linux PM <linux-pm@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] thermal: intel_powerclamp: Use first online CPU as
 control_cpu
Message-ID: <Y0gOI9hiP9NXsuJP@chenyu5-mobl1>
References: <5633735.DvuYhMxLoT@kreacher>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <5633735.DvuYhMxLoT@kreacher>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hwFxn7aJwukxThwoW/9azEcBjGv87UV1zhQqLjyroleVMjNxCm6y/bFcPU7C?=
 =?us-ascii?Q?QIU14qvhCA2tRGulWCk0e/BmlV9RFtbYJdgkWHvicW2X74wvKMHIHp/z/izR?=
 =?us-ascii?Q?z8Offbiq5DAREi7HuEts9vcd8/TA193NtXkrby8cY6mwQNbffmAMTpalhH2X?=
 =?us-ascii?Q?fgu3eTXF1eEOKizYwb0x6xFp7uBVIco48Etn/WnlsHVFFSliEdzHKk8BO4iR?=
 =?us-ascii?Q?RVSPUni2MtUYhpQe6WzkJzFa/eZJE/UU9QXcRmMNfMhHsTj7g25JLervTobj?=
 =?us-ascii?Q?CRdyiFFV3ZEZxV1CpnIRNJl64zJZqxgHtwC1wQGQki6TOmAdTEfT5sXH1MjC?=
 =?us-ascii?Q?mT+3JYiAZZBYFLAMaKAlx5zYm7omMBuJn9LdurhJLy95N3GqlqcNhpHY4us9?=
 =?us-ascii?Q?AyxNlzFk+nGgz6MsMVSO4uHFag52PNnjqOD1qWMvVDaqZgEf2KNc8OIC50xg?=
 =?us-ascii?Q?shwl3561Z5GdmmPPk5JYMjw/JHPmN8KqjLGTH7CDcCCdgMucSaWvx/2bFXK+?=
 =?us-ascii?Q?MXcjQ+8ub6Cm2V+5iDAFLaXDAQA0kLLIuTT5tFVv2OMgzpsray9Ko3B4ALiT?=
 =?us-ascii?Q?OJGIdPOcFKZKM/Bgm2pU1o8JEr6bKHFYshVhWzW1oByErFFxNPINtfOYOWAK?=
 =?us-ascii?Q?hks8rfsVWT79uDDScYUV4m5IaR0sNCj2/M92Qe6hFxet8XJAmIskx4/5coPs?=
 =?us-ascii?Q?IKpSmiQjSDqfv6kuqGppbNQlfMXUejsxE45Kbx7McCcddjY4Oz1NakotWh0i?=
 =?us-ascii?Q?KhRW5eFKrluj9LF54Vw+qKVt6KpK41ijsqbQ38WVtknhgPAVmizBFk8GOC1Y?=
 =?us-ascii?Q?WYE8Tc4bViUYGFfz4OYFDuao8zj/hNYBWjinJGuvCsx1ulnslfb70paNaaFc?=
 =?us-ascii?Q?vQfMA7wGKyyr0uUZz6wY9wmMsQMZd5/KlMXXeY6dlPQuqUOb82OXvPY/bjE5?=
 =?us-ascii?Q?zHaRE8JSzaBH1kJVQTDYIuC79a8qseGeVOJy9jnehw/IYZfAVQpBTeMULI0e?=
 =?us-ascii?Q?r2J4hrF5F+XwDBlmrMn18dKuoqG1uW6RybQ6n/LZFzpJEzSSGJbw2CjZDsin?=
 =?us-ascii?Q?fIptwiBYjy+1cgh2+nAQ9Gsal2EqcIrtWLnGWNaHUauRpnJsSD6Rx5faTIlf?=
 =?us-ascii?Q?MwlfI7VAIBjXCS+kgaFYEUu1/mNfTYinCuS/R/htjaITn9udE2fkADG7x23I?=
 =?us-ascii?Q?deKyuKlneicSAQBt1Me5xIzamec4OJcKECiYWvY6+tyJKqy4reFodi4kkeLX?=
 =?us-ascii?Q?nfAadWSVpu9hA2BhaEJ6UcPuC5AIX0plbGT+18iV8q2mwoVik/S1FrkUeVQx?=
 =?us-ascii?Q?xSMCBMSTnH7bmPOdYiNdLpgEHt/7hloI5qPmhNqrFvBEGuyzrgb4txA2KPdo?=
 =?us-ascii?Q?ymPZrrfeMgiDaF8CpTd5g598CfchYrO6MtnDZLRh1g+jK9SaEsGg82bkNCeR?=
 =?us-ascii?Q?FCEZHD/1L++Kd8d+qsWsyfqPdFaLawaxBWg/xyaaAOlBUG7i23wqVH8oU12j?=
 =?us-ascii?Q?1fkjJeWNid0HKyEhZQLbXR8aHLd7uYvgveRFNB/ep9Cnd1KToBB/gNywN71c?=
 =?us-ascii?Q?d1pLdEty/lY1QysXu5idOyWIA5jm6NYmqqZZLTVb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0683793b-e3bd-4031-e3bf-08daad1c40aa
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 13:10:08.3539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ttsjPNZ6ktfElunuNqA5CLlicnDySAmR1hyhnMYV35WhLwa4zOZZMd+femW8do54GCNRvgjjglpLbHkeFxXG5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4868
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-10-13 at 14:50:28 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Commit 68b99e94a4a2 ("thermal: intel_powerclamp: Use get_cpu() instead
> of smp_processor_id() to avoid crash") fixed an issue related to using
> smp_processor_id() in preemptible context by replacing it with a pair
> of get_cpu()/put_cpu(), but what is needed there really is any online
> CPU and not necessarily the one currently running the code.  Arguably,
> getting the one that's running the code in there is confusing.
> 
> For this reason, simply give the control CPU role to the first online
> one which automatically will be CPU0 if it is online, so one check
> can be dropped from the code for an added benefit.
> 
> Link: https://lore.kernel.org/linux-pm/20221011113646.GA12080@duo.ucw.cz/
> Fixes: 68b99e94a4a2 ("thermal: intel_powerclamp: Use get_cpu() instead of smp_processor_id() to avoid crash")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/thermal/intel/intel_powerclamp.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> Index: linux-pm/drivers/thermal/intel/intel_powerclamp.c
> ===================================================================
> --- linux-pm.orig/drivers/thermal/intel/intel_powerclamp.c
> +++ linux-pm/drivers/thermal/intel/intel_powerclamp.c
> @@ -516,11 +516,7 @@ static int start_power_clamp(void)
>  	cpus_read_lock();
>  
>  	/* prefer BSP */
Above comment line is not true any more, might delete it as well?

Reviewed-by: Chen Yu <yu.c.chen@intel.com>

thanks,
Chenyu
> -	control_cpu = 0;
> -	if (!cpu_online(control_cpu)) {
> -		control_cpu = get_cpu();
> -		put_cpu();
> -	}
> +	control_cpu = cpumask_first(cpu_online_mask);
>  
>  	clamping = true;
>  	schedule_delayed_work(&poll_pkg_cstate_work, 0);
> 
> 
>