Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <81e3a8d8-9c20-6711-f2c9-54c366aab276@baylibre.com>
Date:   Thu, 13 Oct 2022 15:22:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>, lgirdwood@gmail.com,
        broonie@kernel.org, robh+dt@kernel.org, nm@ti.com,
        kristo@kernel.org, dmitry.torokhov@gmail.com,
        krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com,
        will@kernel.org, lee@kernel.org, tony@atomide.com, vigneshr@ti.com,
        bjorn.andersson@linaro.org, shawnguo@kernel.org,
        geert+renesas@glider.be, dmitry.baryshkov@linaro.org,
        marcel.ziswiler@toradex.com, vkoul@kernel.org,
        biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com
Cc:     afd@ti.com, narmstrong@baylibre.com, msp@baylibre.com,
        j-keerthy@ti.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-input@vger.kernel.org, linux-omap@vger.kernel.org
References: <20221011140549.16761-1-jneanne@baylibre.com>
 <20221011140549.16761-7-jneanne@baylibre.com>
 <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org>
 <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com>
 <fc1e5799-20ea-de37-6693-e2ea0fb87f13@linaro.org>
 <7hzge1hqof.fsf@baylibre.com>
 <8d27a5f6-461a-5b28-1560-07bb4ddcaa8a@linaro.org>
From:   jerome Neanne <jneanne@baylibre.com>
In-Reply-To: <8d27a5f6-461a-5b28-1560-07bb4ddcaa8a@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 13/10/2022 14:32, Krzysztof Kozlowski wrote:
> On 12/10/2022 13:56, Kevin Hilman wrote:
>> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
>>
>>> On 12/10/2022 04:39, jerome Neanne wrote:
>>>>> You explained what you did, which is easily visible. You did not explain
>>>>> why you are doing it.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>> Thanks for pointing me to the detailed guidelines
>>>> I'm new to upstream and not well aware of all good practices.
>>>>
>>>> Would below commit message be more suitable:
>>>>
>>>> Add support for the TPS65219 PMIC by enabling MFD, regulator and
>>>> power-button drivers.  All drivers enabled as modules.
>>>
>>> This still says only what you did. I still does not explain why.
>>
>> Jerome, maybe adding a bit of preamble like:
>>
>> "Development boards from TI include the TPS65219 PMIC.  Add support..."
> 
> I would propose: "Development boards from TI with xxx SoC include the
> ..." because the point is that you use this defconfig for boards for
> given SoC (supported by upstream).
> 
> Other way would be "Foo-bar development board includes the TP..."
> 
>>
>> Krzysztof, I'm the first to argue for descriptive/verbose changelogs,
>> but IMO, this is getting a little bit nit-picky.
>>
>> The series adds a new driver, DTS and defconfig patches to enable
>> support the new driver.  The "why" for changes to defconfig changes like
>> this are kind of implied/obvious, and there is lots of precedent for
>> changelogs of defconfig changes for simple drivers to simply say "enable
>> X and Y".
> 
> While I understand the entire patchset, the defconfig goes via separate
> tree/branch and must stand on its own. Later (one month, one year, one
> decade) someone will look at history and wonder why the heck we enabled
> TPS65219.
> 
>>
>> If my above suggesion is not enough, please make a suggestion for what
>> you think would qualify as an appropritate changelong that answers "why"
>> for a simple driver change.
> 
> It is enough :)
> 
> Best regards,
> Krzysztof
> 
Got it! I'll rephrase following your suggestion