Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp885066rwi; Thu, 13 Oct 2022 06:32:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7HwQ9DiRYwK69hlquA3/h6K10FQ5I47a0P/8d1zqpOx+ZRCqeUaZ4UNQvCYgTmWeF4DOek X-Received: by 2002:a17:906:9749:b0:782:287f:d217 with SMTP id o9-20020a170906974900b00782287fd217mr26499825ejy.259.1665667947725; Thu, 13 Oct 2022 06:32:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665667947; cv=none; d=google.com; s=arc-20160816; b=o5/NYuEbJzlfNDoJ7vcyZthDwh78lWcLUdCGq8wGH+lTmTCapn6g2TUh++weMppetf lFSQyrqUHViMsFk9P+iJV8rJw09CLGMDHjk8nS76cFgrW7N1E44RUH68xWpWM4OlCb4M ct6WOeZKrhleLPx7diTpyr+fuQ5Hvrc8WSotthjYSzm9EeyuS4o72F4cRwIzBojHfIae 2QEmHfMUSsXo7Q5d1fAvovn/rIIrpO1OVsjxNqVJLXA6Hd6WL7yoo7x8LQcVBOnW4Hun Pw0s8Zfmg5zGh03wFpzVi7M90TgjiMnZ4jYveBUtnhkBLDnIeTX4MYS6celSAjJrdEvS ylLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=y9uxaa0EZxU5gw99ILPe4DQpyZkwwhtfnDgtAW8Ncy0=; b=vizezB7ptbN7GEGmpYvxy/AEuWAe7m+ABCU4Fs22TH+4lzyJiLyZ4RU8Epjf5xVTdi 8BzDGvOitpBb9ljoyUoIsN+RiU/K9Y8YxBwQd8zjRUw0mXRpznvBrNuMYDQyZROMZYoX aSEVVJMnFjsss2hZQxlXvLXDERloGriAWHpCvNzo/Bygt9EU6ikplw5gb6/kXdYNbXmP /EMksxu25uNwWtGHsjGnFouSO1cRDvBwOAK7w0EQwkY0R3E58vvzudcN6UuessuTUd58 9Fp+s0XHhiq1e5LbsoBERdzO9vZ748BNBbbOrHvqsqVXnoh8PTBhnbocOfc7zGXLEigw 1trA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp16-20020a1709071b1000b00781b66e7065si19270044ejc.240.2022.10.13.06.32.00; Thu, 13 Oct 2022 06:32:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbiJMNNl (ORCPT + 99 others); Thu, 13 Oct 2022 09:13:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229894AbiJMNNc (ORCPT ); Thu, 13 Oct 2022 09:13:32 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EECD15E0C3 for ; Thu, 13 Oct 2022 06:13:31 -0700 (PDT) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Mp8ws0BhqzVj8H; Thu, 13 Oct 2022 21:09:01 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 13 Oct 2022 21:13:29 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 13 Oct 2022 21:13:28 +0800 From: Yang Yingliang To: CC: , , Subject: [PATCH] platform/loongarch: laptop: simplify return of generic_subdriver_init() Date: Thu, 13 Oct 2022 21:12:56 +0800 Message-ID: <20221013131256.776370-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code in generic_subdriver_init() is always negative, the return of generic_subdriver_init() can be simplified. Signed-off-by: Yang Yingliang --- drivers/platform/loongarch/loongson-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/loongarch/loongson-laptop.c b/drivers/platform/loongarch/loongson-laptop.c index a665fd1042ac..572290abf151 100644 --- a/drivers/platform/loongarch/loongson-laptop.c +++ b/drivers/platform/loongarch/loongson-laptop.c @@ -523,7 +523,7 @@ static int __init generic_subdriver_init(struct generic_sub_driver *sub_driver) err_out: generic_subdriver_exit(sub_driver); - return (ret < 0) ? ret : 0; + return ret; } static void generic_subdriver_exit(struct generic_sub_driver *sub_driver) -- 2.25.1