Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Oct 2022 14:35:27 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>
Cc:     linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v2 SPI for-next 2/2] spi: microchip: pci1xxxx: Add
 suspend and resume support for PCI1XXXX SPI driver
Message-ID: <Y0gUH1fbB/LijKLw@sirena.org.uk>
References: <20221006050514.115564-1-tharunkumar.pasumarthi@microchip.com>
 <20221006050514.115564-3-tharunkumar.pasumarthi@microchip.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="/peYUdyb9zf/jKcQ"
Content-Disposition: inline
In-Reply-To: <20221006050514.115564-3-tharunkumar.pasumarthi@microchip.com>
Precedence: bulk


--/peYUdyb9zf/jKcQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 06, 2022 at 10:35:14AM +0530, Tharun Kumar P wrote:

> +static int pci1xxxx_spi_resume(struct device *dev)
> +{
> +	struct pci1xxxx_spi *spi_ptr = dev_get_drvdata(dev);
> +	struct pci1xxxx_spi_internal *spi_sub_ptr;
> +	u32 regval = SPI_RESUME_CONFIG;
> +	u8 iter;
> +
> +	for (iter = 0; iter < spi_ptr->total_hw_instances; iter++) {
> +		spi_sub_ptr = spi_ptr->spi_int[iter];
> +		spi_master_resume(spi_sub_ptr->spi_host);
> +		writel(regval, spi_ptr->reg_base +
> +		       SPI_MST_EVENT_MASK_REG_OFFSET(iter));
> +
> +		/* Restore config at resume */
> +		store_restore_config(spi_ptr, spi_sub_ptr, iter, 0);
> +	}
> +
> +	return 0;
> +}

There should be a call to spi_controller_suspend() in here (and
similarly in resume) to tell the controller to stop the queue of
operations.

--/peYUdyb9zf/jKcQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmNIFB4ACgkQJNaLcl1U
h9C0mgf/cX24A/BrVWf33R8t8kuqByOzEhxH0WGgkAejAd9uxSogJxkrsX9hVnkG
baNvviWqDg4o7jvYl6c2uM57pjbkmycVqHiM1EzHKD60JFaK+fkA74UXMTFuRA2Z
pEdVS65rle7wM5YFttaQD8us9+7zwTr7rcy05si/RQd2UIsiUgx+5fMFaj037dPA
kXafwNEAVrGNNqRdAPXDZ9KfCKubFhGN7Mk8WSJVhyno4vwok+SPkrDOZTWz2Jxi
96p8HhZ9lMDdh06ROTvl+MwlZRTGqfcWASHYAgB6n16OmhZ0HCBXCK7rj4Ix1Ddq
6SzSZ27eUE3DidcdrdlhgZn1mH7/BA==
=5++5
-----END PGP SIGNATURE-----

--/peYUdyb9zf/jKcQ--