Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp909903rwi; Thu, 13 Oct 2022 06:51:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4S/RnV+LBXlI04BBePC/E8omxCxEjA8sfBE9nMPqNUbVneglgWa1b7N5QauS8jqT2gH9qv X-Received: by 2002:a17:906:5a48:b0:78e:18a1:32ba with SMTP id my8-20020a1709065a4800b0078e18a132bamr1453319ejc.346.1665669107351; Thu, 13 Oct 2022 06:51:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665669107; cv=none; d=google.com; s=arc-20160816; b=OtqF9aTykUbMtQJj6guy2ppkOXiBeo9c272tUvK6AOBVbBGfG4skNUXNogYAHR/OLn NCV7rMKEUretbshHy5U0vcYhrDKqK2siLeKNA0c7yaBKjdNPaeVqbYDdxXkBd0ic0XxF Yz59aUNNdT1jj5j7XRzhiP9W+qIGzEpvljgWJ6vbhB2AoAkzr5hxdxMO83oeSs9rA+wc PSz3AKuWXwIMlvhE+FyHI24Hvwi7+rkvrJ7vyaksR/o3o/XvhFs2HaYIJ0vDuUncDEh3 wNHvzv6ETh0HgBRSbwZBpzfAGRmDyfPg6pwiS+Qetf8Vuy60CNjB0+x1LVwqx4fK00k+ 0Vdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Qo6+8FjdF5OYwlAv7WYxwDWRkLYYDkW4CdaVk0AWBlc=; b=RMx5Zr2hb/ATO7zUufbjJIboCdFqzd7SmyCczAlChwFtqtPaYbYq9vMMMasX+VpyOq ErnU0phEc6tgiLE8zppK/UtMkfcaBfjfTcthlzH1i79EGHAqWjnutvXgrRQ8pKR6OMwQ 5Cal2bRFW0BVEkDrkF08QCcqgJA6zJqfaJ7X5uucOB+MkstH1/et5MxLQJZnXPubRiaT eCZJRgRxVCE+cZCc3z5ZU39NR1ZJaQ4FNOdJQwDWJno4poJE0P5W67FhxUzys3l+jISN 6de4O14L/WgxSAenI6epYNGzIsrIVcqrP+G8j6DLefcuouzi7e3F29n07L/jBHmGIz8s uqeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ez4+evfA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc17-20020a1709078a1100b0073d9c412570si10859746ejc.785.2022.10.13.06.51.21; Thu, 13 Oct 2022 06:51:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ez4+evfA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229526AbiJMNVl (ORCPT + 99 others); Thu, 13 Oct 2022 09:21:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbiJMNVi (ORCPT ); Thu, 13 Oct 2022 09:21:38 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17CDA24F1E; Thu, 13 Oct 2022 06:21:33 -0700 (PDT) Received: from zn.tnic (p200300ea9733e733329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e733:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5E0EC1EC054C; Thu, 13 Oct 2022 15:21:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1665667287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Qo6+8FjdF5OYwlAv7WYxwDWRkLYYDkW4CdaVk0AWBlc=; b=ez4+evfAyCw8CJwXC5ithv3jA4BbyEI7l/tCwIJvkT3uhCyrd0+xmhFSMG5zvCM/DR1FMA TREUZN2tS4EDk9uZyP0qz+3/DKDCNOel8C3mT1lXjJEY6jvMXwbXuneET1Y2j/egGB/nvH JYvjVOJIdBLEKZk5Mk96dk7NJujljEg= Date: Thu, 13 Oct 2022 15:21:23 +0200 From: Borislav Petkov To: Sathyanarayanan Kuppuswamy Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, Shuah Khan , Jonathan Corbet , "H . Peter Anvin" , Greg Kroah-Hartman , "Kirill A . Shutemov" , Tony Luck , Kai Huang , Wander Lairson Costa , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v14 2/3] virt: Add TDX guest driver Message-ID: References: <20220928215535.26527-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220928215535.26527-3-sathyanarayanan.kuppuswamy@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 12, 2022 at 04:01:31PM -0700, Sathyanarayanan Kuppuswamy wrote: > I am fine with adding an error message here. What about the above -EINVAL > case? Do you suggest adding it there as well? Right, you could dump the req.* fields it read from luserspace so that one staring at the error message can actually see which of the fields failed the check. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette