Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Oct 2022 17:21:35 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     "Hans J. Schultz" <netdev@kapio-technology.com>
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yuwei Wang <wangyuweihx@gmail.com>,
        Petr Machata <petrm@nvidia.com>,
        Florent Fourcot <florent.fourcot@wifirst.fr>,
        Hans Schultz <schultz.hans@gmail.com>,
        Joachim Wiberg <troglobit@gmail.com>,
        Amit Cohen <amcohen@nvidia.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v7 net-next 4/9] net: switchdev: support offloading of
 the FDB blackhole flag
Message-ID: <Y0ge76Afxpc2DOsn@shredder>
References: <20221009174052.1927483-1-netdev@kapio-technology.com>
 <20221009174052.1927483-5-netdev@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221009174052.1927483-5-netdev@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rxO86z92rEW3mUyW4AO06LsSIT9JG4j/rTqQfvWsG/DNsIdjsiYJyPqaTpRK?=
 =?us-ascii?Q?b52YoIwMT2Tf7gJ5e/mJHsKdBYEjGjqWDrnxNfYnYsL7Rnl0SLl1cOLWaRWG?=
 =?us-ascii?Q?z7R4IEmZT0ZBOoLq5XZ1N5V4417abmC6P44AJmco6PHTpKJhQV1P7PzcoTcD?=
 =?us-ascii?Q?xb0wdkInju92jmZfneF/IDWQa9kSC6Yg4jtg2kgNeDXcTw2VPBd8mZ/6tpRH?=
 =?us-ascii?Q?RSILD6RdJDjGAwiTFzPe1zUwfk40flNEjemCyuVkFVbhVBphpGztbKF8Sr36?=
 =?us-ascii?Q?IETjPfTbWeTZ3wKv5XHBPtRElWd8LFvPG730UBBBTu2n+rx0OBYaJ8dEw6ON?=
 =?us-ascii?Q?CDGSzwtu91CAZr8v0QWSY0D8mdxUDmrIu+YhKA+kFbNOBqMjRncIRUjRp44I?=
 =?us-ascii?Q?7biyewxFxUf0ZcZTlGWbXhk+srF/Buj0VwoBKPy60Q+YgCPimx+K7IOuoiP3?=
 =?us-ascii?Q?St0PhJbcWjC7AO1vTsM9c0cIfGaPHaMdRkNAhXAyGQ5kgJiO1qKoo52eyAH/?=
 =?us-ascii?Q?pWFHgwZhrolHdDmtzJdYv0MF6IDGpR0hYoxKx3rmnCiyoyZWIL6PZVIUPhM1?=
 =?us-ascii?Q?WqQooSyB7atWzm+NKFqYsmeLAg+QU6kZI4IbAWlYoEYx86vi4Q4xLi76nsrU?=
 =?us-ascii?Q?iouGrPrU9YjnKXg3T0ywVoiIQqI1BmE8vCxG7xH/GiPP2qM4TegSXSUcNdjS?=
 =?us-ascii?Q?mzSzbGejdL31vNQ1QU+P2cZiJuO0Cbdsj4Gvyx0aPn8xv9mvQ4iPxiYnIWUO?=
 =?us-ascii?Q?QFaJH7S5Sc/9f+xHtNciueZBe93SeacoZJOqrZet7vc4ESBpYEHNLv9wcFyO?=
 =?us-ascii?Q?4K5YNWG3mIRaDI+Z2ozSRlFzgXCuCp40k9jlnrzRCdsLYA8/XE2e2+R8ln2M?=
 =?us-ascii?Q?xRCtXZJt01sBMTqV7zdiHXFrcRlXMQWHmxjgH94q0q3TUZe3DyEyq0MBP3w6?=
 =?us-ascii?Q?BFDJEyt7GeMpnoBWnIPQbhNSoQTF7+jLM5oH81lg4kP5Vv5/zr5aBOhFTT+c?=
 =?us-ascii?Q?2sANcGsz80rgGu0tCo+Ebur5hTW+OIFj0xUpdw3XjutNURfOVAVubjhaYuVY?=
 =?us-ascii?Q?4Z75ZtebI9yrK5HjqWfKfwrK02BKkl8IYqOgLn/Mxv0ACGp4zNrdrWTgCmzl?=
 =?us-ascii?Q?GGW22AfJ2ORxMgx75a5iyLAxW99jS/Xv+PC/gwdFJ4chJqHiGoq6J9MOOF5V?=
 =?us-ascii?Q?BPQ9yQPHWfD96w19Ln0MXnweM71XpG2fq4czhqQOCUeQ9U2exFrQ5W4Udij0?=
 =?us-ascii?Q?3tZYa0nSHCE2yH8yqisyRaPR33GunsPNwwsv9O3CV/v/2f/OgLceSBGbX3aY?=
 =?us-ascii?Q?eKD60XLSfr8jF8O/QvVxTlA1ZwMBNVwVGCfijgJdUfy+tR9hahgIn2VLsr1z?=
 =?us-ascii?Q?NNINtt0QeMu3itUwWUUPf8WFDvdYBWmv5ZZmnShGDyL5BxwCrFq/XIYLD6UI?=
 =?us-ascii?Q?eZOcFRHQ2+QTCG1OIzV75E04k7hvYFK1xyQqHiuQuHBymexCM1PV7rdajMcG?=
 =?us-ascii?Q?3G0iILO4KkR5fwurkRPtfxZyWE95EsN1cwmdyY88rPZz2ery4gMDTjeg0oP3?=
 =?us-ascii?Q?cUUcfY1IJupPZZA0uuwpzGuqA9B/ltPU6Q0bZYFo?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc7d6b04-4adf-40f9-e514-08daad263fcc
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 14:21:41.8819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vUTbullLmGFQJknm9jDYGS7QREePCZMxGb5zYKU8xMm0tCF+NaexkAKjn8Xdaklh2J+l/x2BWUExL+5kVMsR/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6404
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 09, 2022 at 07:40:47PM +0200, Hans J. Schultz wrote:
> Add support for offloading of the FDB blackhole flag.
> 
> Signed-off-by: Hans J. Schultz <netdev@kapio-technology.com>
> ---
>  include/net/dsa.h         |  1 +
>  include/net/switchdev.h   |  1 +
>  net/bridge/br.c           |  3 ++-
>  net/bridge/br_fdb.c       | 19 ++++++++++++++++---
>  net/bridge/br_private.h   |  3 ++-
>  net/bridge/br_switchdev.c |  1 +
>  net/dsa/dsa_priv.h        |  4 ++--
>  net/dsa/port.c            | 22 ++++++++++++----------
>  net/dsa/slave.c           |  6 ++++--
>  9 files changed, 41 insertions(+), 19 deletions(-)

Too many changes at once. I suggest to split into:

1. A patch that allows the bridge driver to be notified about blackhole
entries from device drivers and also notifying it to drivers when added
from user space. These changes:

include/net/switchdev.h   |  1 +
net/bridge/br.c           |  3 ++-
net/bridge/br_fdb.c       | 19 ++++++++++++++++---
net/bridge/br_private.h   |  3 ++-
net/bridge/br_switchdev.c |  1 +

2. The DSA changes