Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7e2043b9-c7fa-236e-de19-5e290deebbdf@linuxfoundation.org>
Date:   Thu, 13 Oct 2022 09:58:06 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] power: cpupower: utils: Optimize print_online_cpus and
 print_offline_cpus function
Content-Language: en-US
To:     kunyu@nfschina.com
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        ray.huang@amd.com, shuah@kernel.org, trenn@suse.com,
        Shuah Khan <skhan@linuxfoundation.org>
References: <14d690a4-d2d5-01db-b2a2-e3c87b4a6394@linuxfoundation.org>
 <20221013020121.2874-1-kunyu@nfschina.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20221013020121.2874-1-kunyu@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/12/22 20:01, Li kunyu wrote:
> 
> I'm glad to get your reply. In previous tests, it was found that variable initialization and assignment use mov related instructions. Therefore, when I analyze the code and find that removing some variable initialization and assignment does not affect the function and security, I will try to remove variable initialization.
> 
> Find the malloc function and find that its return value is void * type, so it does not need to cast.
> 
> thanks,
> kunyu
> 

I am not seeing any reasons for removing the initialization.
There is no need to do that.

Missing error handling after malloc() call is the real problem
that can be fixed in this code path.

If you would like to fix that, send me a patch for that.

Hmm. Your reply to list looks strange - please double check and fix it

"Re:[PATCH]"@lists.nfsmail.com etc...

thanks,
-- Shuah