Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1524663rwi; Thu, 13 Oct 2022 15:15:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4J8qgmuuZtkf4FOfrdynAryqet+A4tf45NLXlpyQuaarkmt3FOT+LUHEQtLvhhBPvDslAB X-Received: by 2002:a17:902:f682:b0:178:3ede:a12f with SMTP id l2-20020a170902f68200b001783edea12fmr2225566plg.26.1665699308760; Thu, 13 Oct 2022 15:15:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665699308; cv=none; d=google.com; s=arc-20160816; b=MAd1qZFeP703SxVM7Tm+7AXiAthzD2yenZLkudd2JsnqYAwjwhObdT/xZPQsSgsPaC UeJydiSIHCazA9VkJAYpq4wjU2mrIC2eL3HR2CrT50db9Sei2Dqsn0xafN6AhHjTc1Ha LRDvl2vgdQqTaj/CxQ7I6Pu4WFZxWCe2VT+cYgMV/zPcQaFbeNeWPiJbuYc0yD91OQCK XplbjUqk/39VAnNB5mmcebaoqUjq3QS+8QgCB5+x7omuncL0FDH38855b+OqoHOOHz+N fK/tcLKqzH7MjcLBFGSBar+vOuAj0yzIEIjH0bDxDfGwdd3Vvbc0y83OS1tHXBd5VRei BBdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=AuZeE99nHpI9FLZS7DWkmnLcMEnUvxSwO0ppzfO1zvo=; b=x0ByTgmgtDN84z2SyVA7h6/ujyOu85/Elgq7s7knF+Cz7vS5BmT+yy6pLD+Pl6rRV9 4sYC8KYglF6GGSWVD1DHuD/Lebtxhj6SUCzvBQOMmeD4ezQDJOMuvs8Nn2IJaO5ksQ25 zLOYWv5DUhR7CyFvaypJgPLJTynlCTXxpy+ajWzN0YWba37RQKRbrYGJqeSLtfNZAZ4i 2ksU7jJwFmeTPOybIdDr3xSiuEY9+vjOVy2zhAb6Smn/AsbGVsqKQ3cjTwwbsdVZPGWu 7axzM2VLqt4GPk2nuhIHhVkp476O5yerrCtYJ48oP7LvH/KoiPanO6KUXpBSrwv0CuQw LaqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b21-20020a63d815000000b00439f012ca81si624572pgh.605.2022.10.13.15.14.54; Thu, 13 Oct 2022 15:15:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230124AbiJMVvo (ORCPT + 99 others); Thu, 13 Oct 2022 17:51:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230363AbiJMVvQ (ORCPT ); Thu, 13 Oct 2022 17:51:16 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B93BF36BFA for ; Thu, 13 Oct 2022 14:49:54 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oj651-0003l1-Su; Thu, 13 Oct 2022 23:49:27 +0200 Message-ID: <849213369ce9ed3364ba0beb2744bfbcb3740b0c.camel@pengutronix.de> Subject: Re: [PATCH V4 0/7] imx: blk-ctrl: Add interconnect for i.MX8MP From: Lucas Stach To: Tim Harvey , Marek Vasut Cc: "Peng Fan (OSS)" , djakov@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, abelvesa@kernel.org, abailon@baylibre.com, laurent.pinchart@ideasonboard.com, paul.elder@ideasonboard.com, Markus.Niebel@ew.tq-group.com, aford173@gmail.com, kernel@pengutronix.de, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, Peng Fan Date: Thu, 13 Oct 2022 23:49:25 +0200 In-Reply-To: References: <20220708085632.1918323-1-peng.fan@oss.nxp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tim, Am Donnerstag, dem 13.10.2022 um 11:23 -0700 schrieb Tim Harvey: > On Wed, Oct 12, 2022 at 11:46 AM Tim Harvey wrote: > > > > On Tue, Oct 11, 2022 at 4:13 PM Marek Vasut wrote: > > > > > > On 10/11/22 22:10, Tim Harvey wrote: > > > > On Fri, Jul 8, 2022 at 1:57 AM Peng Fan (OSS) wrote: > > > > > > > > > > From: Peng Fan > > > > > > > > > > V4: > > > > > Because the header is not included when adding NoC node, the fsl,imx8mp.h > > > > > needs be included in this patchset. So include it in patch 6 > > > > > > > > > > V3: > > > > > Move adding NoC node patch to i.MX8MP ICC driver patchset > > > > > Per Lucas's comments, warn once when icc bulk get not return probe defer and continue. > > > > > > > > > > V2: > > > > > Use a low bandwidth value instead INT_MAX > > > > > Minor fix to move fsl,imx8mp.h out to dts patch, not driver patch > > > > > Add A-b tag from DT maintainer > > > > > > > > > > i.MX8MP NoC settings is invalid after related power domain up. So > > > > > need to set valid values after power domain up. > > > > > > > > > > This patchset is to bind interconnect for each entry in blk ctrl. > > > > > > > > > > This patchset is not include DVFS DDRC feature. > > > > > > > > > > Peng Fan (7): > > > > > dt-bindings: soc: imx: add interconnect property for i.MX8MP media blk > > > > > ctrl > > > > > dt-bindings: soc: imx: add interconnect property for i.MX8MP hdmi blk > > > > > ctrl > > > > > dt-bindings: soc: imx: add interconnect property for i.MX8MP hsio blk > > > > > ctrl > > > > > soc: imx: add icc paths for i.MX8MP media blk ctrl > > > > > soc: imx: add icc paths for i.MX8MP hsio/hdmi blk ctrl > > > > > arm64: dts: imx8mp: add interconnects for media blk ctrl > > > > > arm64: dts: imx8mp: add interconnect for hsio blk ctrl > > > > > > > > > > .../soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml | 9 +++++ > > > > > .../soc/imx/fsl,imx8mp-hsio-blk-ctrl.yaml | 10 +++++ > > > > > .../soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 14 +++++++ > > > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 18 +++++++++ > > > > > drivers/soc/imx/imx8m-blk-ctrl.c | 39 +++++++++++++++++++ > > > > > drivers/soc/imx/imx8mp-blk-ctrl.c | 35 +++++++++++++++++ > > > > > 6 files changed, 125 insertions(+) > > > > > > > > > > -- > > > > > 2.25.1 > > > > > > > > > > > > > Hi Peng, > > > > > > > > I built origin/master from commit 041bc24d867a today for an imx8mp > > > > board and am running into errors that appear to be introduced by this > > > > series: > > > > [ 15.177372] platform 381f0040.usb-phy: deferred probe pending > > > > [ 15.183155] platform 382f0040.usb-phy: deferred probe pending > > > > [ 15.188928] platform 33800000.pcie: deferred probe pending > > > > [ 15.194439] platform 32ec0000.blk-ctrl: deferred probe pending > > > > [ 15.200287] platform 38330000.blk-ctrl: deferred probe pending > > > > [ 15.206129] platform 32f10000.blk-ctrl: deferred probe pending > > > > [ 15.211974] platform 32f10100.usb: deferred probe pending > > > > [ 15.217382] platform 32f10108.usb: deferred probe pending > > > > [ 15.222791] platform cpufreq-dt: deferred probe pending > > > > # cat /sys/kernel/debug/devices_deferred > > > > 381f0040.usb-phy platform: supplier 32f10000.blk-ctrl not ready > > > > 382f0040.usb-phy platform: supplier 32f10000.blk-ctrl not ready > > > > 33800000.pcie platform: supplier 32f10000.blk-ctrl not ready > > > > 32ec0000.blk-ctrl imx8m-blk-ctrl: failed to get noc entries > > > > 38330000.blk-ctrl imx8m-blk-ctrl: failed to get noc entries > > > > 32f10000.blk-ctrl imx8mp-blk-ctrl: failed to get noc entries > > > > 32f10100.usb platform: supplier 32f10000.blk-ctrl not ready > > > > 32f10108.usb platform: supplier 32f10000.blk-ctrl not ready > > > > cpufreq-dt > > > > > > > > Is there a driver I'm perhaps missing that is needed now or are there > > > > some patches that come from a different unmerged tree needed? > > > > > > Do you have these enabled ? > > > > > > CONFIG_INTERCONNECT_IMX8MM=y > > > CONFIG_INTERCONNECT_IMX8MN=y > > > CONFIG_INTERCONNECT_IMX8MQ=y > > > CONFIG_INTERCONNECT_IMX8MP=y > > > > Marek, > > > > Yes, I have those as well as CONFIG_ARCH_NXP which appears new for 6.1 enabled. > > > > Best Regards, > > > > Tim > > I see this issue on origin/master 1440f5760228 using > arch/arm64/configs/defconfig. > > It seems to me that the imx8m*_blk_ctrl_probe will all defer now until > perhaps all the drivers using interconnects can probe, such as > g1/lcdif etc? > > Some added debugging shows me: > [ 14.951371] of_icc_bulk_get path lcdif-rd err=-517 > [ 14.956205] devm_of_icc_bulk_get ret=-517 > [ 14.960562] imx8m_blk_ctrl_probe failed -517 > [ 14.967191] of_icc_bulk_get path g1 err=-517 > [ 14.971487] devm_of_icc_bulk_get ret=-517 > [ 14.975614] imx8m_blk_ctrl_probe failed -517 > [ 14.982200] of_icc_bulk_get path usb1 err=-517 > [ 14.986680] devm_of_icc_bulk_get ret=-517 > [ 14.990709] imx8mp_blk_ctrl_probe 0:usb1 > [ 14.994641] imx8mp_blk_ctrl_probe 1:usb2 > [ 15.002086] platform 381f0040.usb-phy: deferred probe pending > [ 15.007875] platform 382f0040.usb-phy: deferred probe pending > [ 15.013636] platform 32f00000.pcie-phy: deferred probe pending > [ 15.019480] platform 33800000.pcie: deferred probe pending > [ 15.024975] platform 32ec0000.blk-ctrl: deferred probe pending > [ 15.030819] platform 38330000.blk-ctrl: deferred probe pending > [ 15.036662] platform 32f10000.blk-ctrl: deferred probe pending > [ 15.042503] platform 32f10100.usb: deferred probe pending > [ 15.047912] platform 32f10108.usb: deferred probe pending > Do you have CONFIG_ARM_IMX_BUS_DEVFREQ enabled? This one will actually instantiate the interconnect devices for the interconnect drivers to hang onto. Once the interconnect is probed the blk-ctrl drivers should probe. There is no dependency into leaf peripheral devices. Regards, Lucas