From: Andi Kleen <ak@suse.de>
Organization: SUSE Linux Products GmbH, Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Subject: Re: [PATCH] x86_64: change _map_single to static in pci_gart.c etc
Date: Wed, 27 Jun 2007 22:26:29 +0200
User-Agent: KMail/1.9.6
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
       "Muli Ben-Yehuda" <muli@il.ibm.com>,
       "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
References: <200706271041.21937.yinghai.lu@sun.com> <200706272222.25153.ak@suse.de> <86802c440706271325w3a8b6d9aybb8a346b9b2eb345@mail.gmail.com>
In-Reply-To: <86802c440706271325w3a8b6d9aybb8a346b9b2eb345@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200706272226.29231.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 779
Lines: 20

On Wednesday 27 June 2007 22:25:11 Yinghai Lu wrote:
> On 6/27/07, Andi Kleen <ak@suse.de> wrote:
> > On Wednesday 27 June 2007 19:41:21 Yinghai Lu wrote:
> > > [PATCH] x86_64: change _map_single to static in pci_gart.c etc
> > >
> > > there function is called via dma_ops->.., so change it to static
> >
> > Actually all these functions shouldn't be inline in the first place.
> 
> do you mean pci_map_single==>dma_map_single==>gart_map_single?

dma_map_single. pci_map_single is ok because it doesn't really 
change anything.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/