Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Oct 2022 16:58:51 -0700
From:   Peilin Ye <yepeilin.cs@gmail.com>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Peilin Ye <peilin.ye@bytedance.com>,
        Cong Wang <cong.wang@bytedance.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4] net/sock: Introduce trace_sk_data_ready()
Message-ID: <20221013235851.GA29973@bytedance>
References: <20221011195856.13691-1-yepeilin.cs@gmail.com>
 <20221012232121.27374-1-yepeilin.cs@gmail.com>
 <Y0fdwSkyoFI2SDuw@unreal>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y0fdwSkyoFI2SDuw@unreal>
Precedence: bulk

On Thu, Oct 13, 2022 at 12:43:29PM +0300, Leon Romanovsky wrote:
> On Wed, Oct 12, 2022 at 04:21:21PM -0700, Peilin Ye wrote:
> > From: Peilin Ye <peilin.ye@bytedance.com>
> > 
> > As suggested by Cong, introduce a tracepoint for all ->sk_data_ready()
> > callback implementations.  For example:
> > 
> > <...>
> >   ksoftirqd/0-16  [000] ..s..  99.784482: sk_data_ready: family=10 protocol=58 func=sock_def_readable
> >   ksoftirqd/0-16  [000] ..s..  99.784819: sk_data_ready: family=10 protocol=58 func=sock_def_readable
> > <...>
> > 
> > Suggested-by: Cong Wang <cong.wang@bytedance.com>
> > Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>
> > ---
> > changes since v3:
> >   - Avoid using __func__ everywhere (Leon Romanovsky)
> >   - No need to trace iscsi_target_sk_data_ready() (Leon Romanovsky)
> 
> I meant no need both trace point and debug print and suggested to remove
> debug print.

Ah, I see.  I will clean up redundant debug prints in
iscsi_target_sk_data_ready(), rds_tcp_listen_data_ready() and
rds_tcp_data_ready() in separate patches.

Thanks,
Peilin Ye