Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE: [PATCH v2 1/2] scsi: ufs: core: Remove unnecessary if statement
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Bean Huo <beanhuo@iokpp.de>, ALIM AKHTAR <alim.akhtar@samsung.com>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        Daejun Park <daejun7.park@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <20221010092937.520013-2-beanhuo@iokpp.de>
Message-ID: <20221014001900epcms2p227bbd97b905dfc284028818e81781f76@epcms2p2>
Date:   Fri, 14 Oct 2022 09:19:00 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <20221010092937.520013-2-beanhuo@iokpp.de>
        <20221010092937.520013-1-beanhuo@iokpp.de>
        <CGME20221010093042epcas2p2462d3c50d81d613574332e3f39d971e1@epcms2p2>
Precedence: bulk

Hi Bean,

> LUs=C2=A0with=C2=A0WB=C2=A0potential=C2=A0support=C2=A0are=C2=A0properly=
=C2=A0checked=C2=A0in=C2=A0ufshcd_wb_probe()=0D=0A>=20before=C2=A0calling=
=C2=A0ufshcd_read_unit_desc_param(),=C2=A0so=C2=A0remove=C2=A0this=C2=A0unn=
ecessary=0D=0A>=20if-checkup=C2=A0in=C2=A0ufs_is_valid_unit_desc_lun()=C2=
=A0to=C2=A0match=C2=A0its=C2=A0function=C2=A0definition.=0D=0A>=20=0D=0A>=
=20Signed-off-by:=C2=A0Bean=C2=A0Huo=C2=A0<beanhuo=40micron.com>=0D=0A>=20-=
--=0D=0A>=20=C2=A0drivers/ufs/core/ufshcd-priv.h=C2=A0=7C=C2=A03=C2=A0---=
=0D=0A>=20=C2=A01=C2=A0file=C2=A0changed,=C2=A03=C2=A0deletions(-)=0D=0A>=
=20=0D=0A>=20diff=C2=A0--git=C2=A0a/drivers/ufs/core/ufshcd-priv.h=C2=A0b/d=
rivers/ufs/core/ufshcd-priv.h=0D=0A>=20index=C2=A0f68ca33f6ac7..2457b005101=
a=C2=A0100644=0D=0A>=20---=C2=A0a/drivers/ufs/core/ufshcd-priv.h=0D=0A>=20+=
++=C2=A0b/drivers/ufs/core/ufshcd-priv.h=0D=0A>=20=40=40=C2=A0-300,9=C2=A0+=
300,6=C2=A0=40=40=C2=A0static=C2=A0inline=C2=A0bool=C2=A0ufs_is_valid_unit_=
desc_lun(struct=C2=A0ufs_dev_info=C2=A0*dev_info,=0D=0A>=20=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0pr_err(=22Max=C2=A0General=C2=A0LU=C2=A0supported=C2=A0by=C2=A0=
UFS=C2=A0isn't=C2=A0initialized=5Cn=22);=0D=0A>=20=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0return=C2=A0false;=0D=0A>=20=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=7D=0D=0A>=20-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/=
*=C2=A0WB=C2=A0is=C2=A0available=C2=A0only=C2=A0for=C2=A0the=C2=A0logical=
=C2=A0unit=C2=A0from=C2=A00=C2=A0to=C2=A07=C2=A0*/=0D=0A>=20-=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if=C2=A0(param_offset=C2=A0=3D=3D=C2=A0=
UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS)=0D=0A=0D=0AThen,=20there=20is=20no=20re=
quirement=20for=20=22param_offset=22=C2=A0argument.=0D=0A=0D=0AThanks,=0D=
=0ADaejun=0D=0A