Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Oct 2022 08:37:18 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        "Peter Zijlstra" <peterz@infradead.org>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>, <rui.zhang@intel.com>,
        <tim.c.chen@intel.com>, Xiongfeng Wang <wangxiongfeng2@huawei.com>,
        Yu Liao <liaoyu15@huawei.com>
Subject: Re: [PATCH v2] x86/tsc: Extend watchdog check exemption to 4-Sockets
 platform
Message-ID: <Y0ivPhN/BgLZXKmu@feng-clx>
References: <20221013131200.973649-1-feng.tang@intel.com>
 <a4860054-0f16-6513-f121-501048431086@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <a4860054-0f16-6513-f121-501048431086@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xr29JEyYXPtEKeRiUuf+iEZo0HgDedno4d0f12TAGI6uWqb0/QwItZKQ2DhJ?=
 =?us-ascii?Q?F8ydI/8PPb1gXob/uZKjxWMzo0BVPP1fRKB5hLV69Bxs0oTuywrwIo3f/6G3?=
 =?us-ascii?Q?LassJSVSRnWIS3FnFS9HWP7xYanp1enscAi3Rm/MW2F32SJr9cvwvUQs+pPU?=
 =?us-ascii?Q?X3wef3rC0MKsjNui8xqVg+WvR45CN5KpvBKdi22/c+piqKhKtwUTGeK+LYWZ?=
 =?us-ascii?Q?o5LTu1RR0+E53b3l0/GJEyLywivOz78TYCs3g2mj9Ii0ew6xyQ3Y9LB+LsLb?=
 =?us-ascii?Q?7pqEM5Ud7FR2TJzJ6FoQH5+HRNvjGoEOLRXdJUbwyCnRw0grDxNb6x+HtA4K?=
 =?us-ascii?Q?cUaoDYpfa9FtBfls3kqB6wpgsVGV4+ICWWAib75E7y1uvSCdpo4F4N3MgbZc?=
 =?us-ascii?Q?KpMnixOyZuFkQ1Tb64t4mBjwbMiN7FkW7z6J5bi21xZF2qlJWmz8y0TJ3Pct?=
 =?us-ascii?Q?W3CL/6V6OYJzI3sGcPzWFv9WofFsNN0+51Fi2eyvsuKRn0rRfP8dGiunPr3D?=
 =?us-ascii?Q?0ifH/dol+WutOOXe5t6GcB0ZTxUDFe42YJ+OOu/leIc51ESPZlJAzIIoqMrW?=
 =?us-ascii?Q?AWpUlN9G43XqPNB7Qr0533dmNWuz2qKvi4lIJUt/ljEngwjL62RLlIr5OKmX?=
 =?us-ascii?Q?AsyR0+wbim1QAo2P7WOnKK8uoMuPBBIhc5XNWyTohmDGbTvjAznOxpFXNAq/?=
 =?us-ascii?Q?gbr9rhWMpP9JWkEnsPhXf/J+XIEoNrMMXSYvexlcf+B6f8nzkbCB82KL4DZ8?=
 =?us-ascii?Q?l2pUKqWw3sLO+QZNnwCasiZ2W8QN9KiWEt2wuYTNrG/mhEs2KnAX8moHTjJC?=
 =?us-ascii?Q?0KNT8Tf8ZNqYhb2GCQrbB/vgZstUB1bX1TpKCSxLC/oVZfCxeOYcFORC5UYc?=
 =?us-ascii?Q?a+XxSHroAX+doq1myEMqzKTmAhFDNjXDy517WBmrH/1Rntk3wlb6SD/HFw36?=
 =?us-ascii?Q?6Uo05bFFb4plhXyDHZBfooqRVkRCxtNBwXE43DXW26KKb6UclfmO9pUwzUlM?=
 =?us-ascii?Q?NswrWwkbZdUPMykMqffwfo4wE7jOJzHMqwsu04IzDTh0xxRe5bQj+4EFFFHm?=
 =?us-ascii?Q?d+SCpMuiRxf989bkx5OSsIlb5bDU49o+uP39E+UoncVEM7lqTfWIcpj6rD/K?=
 =?us-ascii?Q?ge6DwTKXCwttW8QXbgtBEBCU9ORDOus2vxoBmiNvo6Tv4LRtoySqnDNOOZdY?=
 =?us-ascii?Q?uipucVew1L7UePbpUvb03U8JqXhspsrEdxEFEOkXv4Uwq9HWzV7Alho7gEKG?=
 =?us-ascii?Q?tE1yZrXfo9V/sJg3eAuWrgNiQPLEt0CipYhH1K9quZ+ESTGd4hFrKyySApnJ?=
 =?us-ascii?Q?DshnEn6aU3ugn5agS7NMgWAyRWthMXYMvS+p0vxqCW7pp01/UKhRCIjqiTC0?=
 =?us-ascii?Q?B/BuXoDv9a2bQVvKwFISV+9PNdZUd0HQZUr78vg+YrJ9aA2kVTi4tiW5/Llz?=
 =?us-ascii?Q?7sLiVMFLC39ohq/RIxbAIr9HCHDaWgu9uowFSa+/Yp3jzwGhbJJS3Iu6lGif?=
 =?us-ascii?Q?hMgBDQBN3Xi6L/cNjc+yrNI529RwOtfArpmeDrBKIkYpLsLJvEZt1HXzB+0x?=
 =?us-ascii?Q?rSIyJyrEvY40dgv84kOKu+OCIx2tg6aLT0IeFT0/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c6a72d1-7c6f-4e07-f5e1-08daad7c4ba2
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 00:37:38.4273
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7JdsjtebjpD0bS9HniVmZcXo2vNPDQNzHe5bAeiYpisO5xwbus/PPgpNstUvNkdjMr6o+2jt/5smXgQ99XGVkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5561
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 13, 2022 at 09:02:43AM -0700, Dave Hansen wrote:
> On 10/13/22 06:12, Feng Tang wrote:
> > @@ -1217,7 +1217,7 @@ static void __init check_system_tsc_reliable(void)
> >  	if (boot_cpu_has(X86_FEATURE_CONSTANT_TSC) &&
> >  	    boot_cpu_has(X86_FEATURE_NONSTOP_TSC) &&
> >  	    boot_cpu_has(X86_FEATURE_TSC_ADJUST) &&
> > -	    nr_online_nodes <= 2)
> > +	    nr_online_nodes <= 4)
> >  		tsc_disable_clocksource_watchdog();
> 
> I still don't think we should perpetuate this hack.
> 
> This just plain doesn't work in numa=off numa=fake=... or presumably in
> cases where NUMA is disabled in the firmware and memory is interleaved
> across all sockets.
> 
> It also presumably doesn't work on two-socket systems that have
> Cluster-on-Die or Sub-NUMA-Clustering where a single socket is chopped
> up into multiple nodes.

Yes, after you raised the 'nr_online_nodes' issue, Peter, Rui and I
have discussed the problem, and plan to post a RFC patch as in 
 https://lore.kernel.org/lkml/Y0UgeUIJSFNR4mQB@feng-clx/

Which can cover:
 - numa=fake=... case
 - platform has DRAM nodes and cpu-less HBM/PMEM nodes

and 'sub-numa-clustering' can't be covered, and the tsc will be
watchdoged as before.

For numa=off case, there is only one CPU up, and I think lifting this
watchdog for tsc is fine.

Thanks,
Feng