Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Oct 2022 09:14:39 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        "Peter Zijlstra" <peterz@infradead.org>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>, <rui.zhang@intel.com>,
        <tim.c.chen@intel.com>, Xiongfeng Wang <wangxiongfeng2@huawei.com>,
        Yu Liao <liaoyu15@huawei.com>
Subject: Re: [PATCH v2] x86/tsc: Extend watchdog check exemption to 4-Sockets
 platform
Message-ID: <Y0i3/yQSTdTeuIXv@feng-clx>
References: <20221013131200.973649-1-feng.tang@intel.com>
 <a4860054-0f16-6513-f121-501048431086@intel.com>
 <Y0ivPhN/BgLZXKmu@feng-clx>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y0ivPhN/BgLZXKmu@feng-clx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YhKG57z6+JIIvcMVwovK8oiOaHQ/NLDgnR57KhB5GenRXGKxL6XtOrYhdura?=
 =?us-ascii?Q?fKtyO6VGxx/lU/mEQKznu/gSf+vU4DSen+H17gaO+6LkP+P0QSuZ6aV0EkSv?=
 =?us-ascii?Q?w10+h+QlmIcxz+TlQEBjVxj7dyqdCCwYp7pb/bV/CJLME/wHiCBfuftge56q?=
 =?us-ascii?Q?DPUcgIG6lpdYiBrqlofo14OMVM1w2Mc4b7lhzCVCAUXCzqSOscJROW4pBxYX?=
 =?us-ascii?Q?EyrObOU3rfywnYy2eYJPaJ/nvzdhCHaIF5Z4rC/6oWVc8CUQxSSTT/z7sAvW?=
 =?us-ascii?Q?r84VkF+xTjA7o+O1il7FrorPVH1gKX4KB0zDEBArXSIuCB3ByNHtc1TUZ/FT?=
 =?us-ascii?Q?6f97pav6OU18riJlYcN5rvwUtscJgWYo8ja2QXtOh9Kq7Uyh+EtLV9LZeifQ?=
 =?us-ascii?Q?KjzlWIIGjtDjCCYEuHGcvYYT4lj5lWoElfxn8WevfBISTqgTWxFMu7uJiVBq?=
 =?us-ascii?Q?1e1K88FH669+4MigNj3wsV6JAs48hDmjSo2P0HnAKonz3DqRp5fUx+OVS0Lw?=
 =?us-ascii?Q?HZLdWFEZw8wGURIP1Ht1RBuJHLqh1wQpFxpEPble6DPsgupnh/3hXeeFAVMB?=
 =?us-ascii?Q?LWHaNkaNzMZ6vIt1vGjkPtZ96AEfeH2iJjGsEjT3OU+Mg/oGxYfpwqcoDm7G?=
 =?us-ascii?Q?kpvQ/upX1SKINkMpKlKsAqxtv15lpiNbqf7HnYdEjfXtDqfg+ehNKtaB3KK1?=
 =?us-ascii?Q?LDBuHv9zRHXHBkx+VajQpUmtMc9GO/MeNAxivjj88uY0z4SWmyuTSZOF1xxB?=
 =?us-ascii?Q?JhZB0uTl3+pLep5pG8+zcEqM9Hms7LUVgdMfusp9R6HSMounFwXCsD0jtCzh?=
 =?us-ascii?Q?6adqGobSSYdc5Gr8YtjEpG56pGEIehKdS+hUoi+KI7n3tIwu9ObIOZn4qZcA?=
 =?us-ascii?Q?UEljnyu8oMdJN5dAkKa57/KE1poOviqIhBA31D3CGStEJoGI6wRk7OIWHg/Z?=
 =?us-ascii?Q?lriKj7jI1LbGdVVF79MjGlWnO6i6QfPcJHh7Uh4CWPY8YLFC8rSOCVYwyOpF?=
 =?us-ascii?Q?5RX6NiLIoo/hCN5ejuezQ+Ja5Df6EbqzwAslQaSPQiIwJBdaGWhnAbgpHM3i?=
 =?us-ascii?Q?Ivoa3o5KnJjIc9lxDrU4VqFC3vcCUV5PbtdIkI7NTWmeG7wsydIpAZqIoP2L?=
 =?us-ascii?Q?FjStqunCUXRuXNUgRkIZuZ/CoWj6Boc6j85NRtRQ00sSiCQt4i1JOSOIi0ml?=
 =?us-ascii?Q?mtpl5n32W2YYT60Y2R9DYpQ4r1xtb03BpCvy1xnGyDn/ib6ULAeyk9kdf2Rh?=
 =?us-ascii?Q?U9X9uV/D+3VU1JUwOkSYuIVLBQR+Lep/nAS/nbWwPZteyk+ZKwYqBJUXb3rE?=
 =?us-ascii?Q?ZlDGbiSbO2nnJPG4RCWZsU5exWdUtOwAnot2cePH3eCMZhyHlr2P2cKZ6MOX?=
 =?us-ascii?Q?7yXDmAoi5o9CDoVCLeIM8MgCTmmhhYkWtTbFWIyHkrts9qaMxWSfrSh6KP6/?=
 =?us-ascii?Q?TrhSGqae6kp5ARc9hSQpAjnLxhExABnwMdHCHkFRYjGXcuyF60JNbM1ViIy6?=
 =?us-ascii?Q?5Cm6YR2VCLpMEeLd/WakUSStMDPEICrwRMowuhzPd3X7gcw5S0nzzdk09oQt?=
 =?us-ascii?Q?l8NaRIuuMJjLOGcE0O4nqenKIzG6YrsUdZOKTsfk?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a80ffa15-5536-4836-9857-08daad818132
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 01:14:55.7871
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1XIrLy2CkXUIevNWLBXGlVs4xMijtqWZuMq4P7WhiIG2l/v0UcrJQorw7U/f6cQ+LkMPCcrQNN4hfr4RUAOGUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5300
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 14, 2022 at 08:37:18AM +0800, Feng Tang wrote:
> On Thu, Oct 13, 2022 at 09:02:43AM -0700, Dave Hansen wrote:
> > On 10/13/22 06:12, Feng Tang wrote:
> > > @@ -1217,7 +1217,7 @@ static void __init check_system_tsc_reliable(void)
> > >  	if (boot_cpu_has(X86_FEATURE_CONSTANT_TSC) &&
> > >  	    boot_cpu_has(X86_FEATURE_NONSTOP_TSC) &&
> > >  	    boot_cpu_has(X86_FEATURE_TSC_ADJUST) &&
> > > -	    nr_online_nodes <= 2)
> > > +	    nr_online_nodes <= 4)
> > >  		tsc_disable_clocksource_watchdog();
> > 
> > I still don't think we should perpetuate this hack.
> > 
> > This just plain doesn't work in numa=off numa=fake=... or presumably in
> > cases where NUMA is disabled in the firmware and memory is interleaved
> > across all sockets.
> > 
> > It also presumably doesn't work on two-socket systems that have
> > Cluster-on-Die or Sub-NUMA-Clustering where a single socket is chopped
> > up into multiple nodes.
> 
> Yes, after you raised the 'nr_online_nodes' issue, Peter, Rui and I
> have discussed the problem, and plan to post a RFC patch as in 
>  https://lore.kernel.org/lkml/Y0UgeUIJSFNR4mQB@feng-clx/
> 
> Which can cover:
>  - numa=fake=... case
>  - platform has DRAM nodes and cpu-less HBM/PMEM nodes
> 
> and 'sub-numa-clustering' can't be covered, and the tsc will be
> watchdoged as before.
[...] 


> For numa=off case, there is only one CPU up, and I think lifting this
> watchdog for tsc is fine.

Sorry, I was wrong about this. 'numa=off' will still boot all CPUs up,
but skip SRAT table init and only show one node. so this is another
case that the fix patch can't cover.

Thanks,
Feng