Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3b7fc7414f282ca044c24dae280f9bc9533a5b7b.camel@mediatek.com>
Subject: Re: [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators
 unit names
From:   Chunfeng Yun <chunfeng.yun@mediatek.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, <matthias.bgg@gmail.com>
CC:     <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <sam.shih@mediatek.com>, <hanks.chen@mediatek.com>,
        <weiyi.lu@mediatek.com>, <zhiyong.tao@mediatek.com>,
        <andrew-sh.cheng@mediatek.com>, <viresh.kumar@linaro.org>,
        <fparent@baylibre.com>, <mars.cheng@mediatek.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Date:   Fri, 14 Oct 2022 10:43:55 +0800
In-Reply-To: <20221013152212.416661-7-angelogioacchino.delregno@collabora.com>
References: <20221013152212.416661-1-angelogioacchino.delregno@collabora.com>
         <20221013152212.416661-7-angelogioacchino.delregno@collabora.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno wrote:
> Update the names to regulator-usb-p{0-3}-vbus to fix
> unit_address_vs_reg
> warnings for those.
> 
> Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712")
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> index 638908773706..d31a194124c9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 {
>  		id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>;
>  	};
>  
> -	usb_p0_vbus: regulator@2 {
> +	usb_p0_vbus: regulator-usb-p0-vbus {
Can we modify dt-binding of fixed regulator instead of changing the
node name,
since all nodes using fixed regulator may need be changed.

>  		compatible = "regulator-fixed";
>  		regulator-name = "p0_vbus";
>  		regulator-min-microvolt = <5000000>;
> @@ -59,7 +59,7 @@ usb_p0_vbus: regulator@2 {
>  		enable-active-high;
>  	};
>  
> -	usb_p1_vbus: regulator@3 {
> +	usb_p1_vbus: regulator-usb-p1-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "p1_vbus";
>  		regulator-min-microvolt = <5000000>;
> @@ -68,7 +68,7 @@ usb_p1_vbus: regulator@3 {
>  		enable-active-high;
>  	};
>  
> -	usb_p2_vbus: regulator@4 {
> +	usb_p2_vbus: regulator-usb-p2-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "p2_vbus";
>  		regulator-min-microvolt = <5000000>;
> @@ -77,7 +77,7 @@ usb_p2_vbus: regulator@4 {
>  		enable-active-high;
>  	};
>  
> -	usb_p3_vbus: regulator@5 {
> +	usb_p3_vbus: regulator-usb-p3-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "p3_vbus";
>  		regulator-min-microvolt = <5000000>;