Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Oct 2022 13:59:03 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Andrey Konovalov <andreyknvl@gmail.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        kasan-dev <kasan-dev@googlegroups.com>,
        "Kees Cook" <keescook@chromium.org>
Subject: Re: [PATCH v6 2/4] mm/slub: only zero the requested size of buffer
 for kzalloc
Message-ID: <Y0j6p1TSaLo18qQP@feng-clx>
References: <20220913065423.520159-1-feng.tang@intel.com>
 <20220913065423.520159-3-feng.tang@intel.com>
 <CA+fCnZfSv98uvxop7YN_L-F=WNVkb5rcwa6Nmf5yN-59p8Sr4Q@mail.gmail.com>
 <YzJi/NmT3jW1jw4C@feng-clx>
 <CA+fCnZdvqZzCU_LO178ZsPDvs-Unkh2iZ4Rq5Amb=zS31aWFpA@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CA+fCnZdvqZzCU_LO178ZsPDvs-Unkh2iZ4Rq5Amb=zS31aWFpA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uA82IrKNArHYl+N4bhxmcCdxMvo4aZkSyisI8LJiustWboxWfkVT6n/gGdv2?=
 =?us-ascii?Q?gxEYgcwe8X1b86Zxo+VPZmQq4H9u0t7+i8SB5WdDZU8OZB7jFcY+CdJO04uS?=
 =?us-ascii?Q?ux5fZqXdNr1YFwlVAhRvuffeWZElbzz+ofoMOO5xBy05qiCGImL3T7jU5Opa?=
 =?us-ascii?Q?ZI/aNWJ+b4CUaDQY550VGw2R96QULlQ9+dXrXLT+p3gfkssrpv8Pk9Nwo7s3?=
 =?us-ascii?Q?Jf8Z3Ae1dyWlJvoozZG+YaVmimRB8HeXrDQtJCj4VRohcIVDeaHQE1v8XQBD?=
 =?us-ascii?Q?AMQ704Otc63knbdgab0qtNs/YTn7b43Xh+xAcQH5ZUA6aucROJcHoOJCEHug?=
 =?us-ascii?Q?9EMz4JXcIsMrtHDy6Ow9DBmQm8TrxnAOjtYd0qJKRIe3MS5xEA3gRpJ4sl55?=
 =?us-ascii?Q?QgXEssL+++VstbmWBqtL+FSHu2hRTnwBTYeIrjzirllsGPx8MbZXWKj93buZ?=
 =?us-ascii?Q?4vNGovjZrnQNjogmDuhIrGWP7OvcXUq++YVAoJXi+I5aE1C0gXlaUvD3cSEl?=
 =?us-ascii?Q?Pn5CadntAwN2IshuBMm5Os5N12Oq0iSmvNvzoWt+Qjw1m5d0wOZQlJSkp9U0?=
 =?us-ascii?Q?/Mw2HXy+g5PgUYZgbhuUZqxIawmMDgXaOU/UTrp+oGJbLoAEbDMGUvITAI8B?=
 =?us-ascii?Q?oqzHprEa/KcxTJAfuz5ERV9F26LU4cU1/CHhH6u2PQv7TgNydSc2mv4CQTfr?=
 =?us-ascii?Q?g9Ge5bOwAIv6RJjQDwTtrjZH2YUa+tGzL2kgvXA2lQ7I6TMRls6lnc22L+cQ?=
 =?us-ascii?Q?awFAZ2LzhvLCyLP8RmFrSLW7t+gqu2FBlQwvnbJmT5zyqcJudHUQNMNIseV2?=
 =?us-ascii?Q?6dO+74Nt2aCCJXqcHU5BUtSG4cctqtX7RNfi7vLi7hh9nhshkL0uaFSYdUM0?=
 =?us-ascii?Q?nCENOYOk/tPIfD78So6E56Cw26YLxYYcQzKfkzWF89JuGtepZdGm3redZQMA?=
 =?us-ascii?Q?UGR3bti5eYVRYpH0c4s+8OYQyLnMDmYVcEvxvGFQlV0ccZwX9v+mt6WoKl5a?=
 =?us-ascii?Q?lXDEw3tXRN0PxzvdEmLikbHEBHbLjZWHLvz5Zra/1d/2QNoAcmqSe888iR6O?=
 =?us-ascii?Q?rgXlhFPdgxnj+yPARn2Gyi2d32VWojdL/f1tkE5poC+N+cLbbVj+o6YfLTaU?=
 =?us-ascii?Q?vXHmOwgG6KOQ6cUbiAUXFCPm+OZCCRfHrUgD5d0vjJV26uNkIiTwhoaYTgRO?=
 =?us-ascii?Q?Yf90bNE9svPMuvP1e++IM5b2oPhRo5fp6Uczrzv2HN/0PBja0jgjU9tHncpW?=
 =?us-ascii?Q?XYJxoWxb35gJBsNedFY11Z9Y5sg83ExBJiIbPNUaaYT3z3WvnNvnrOkIi3ZG?=
 =?us-ascii?Q?fmOhRGbJfT8rLQcp0QXhPYc2ZJf6sGP2jce/BdPupxL7qsvWhRZmw8PHYD6J?=
 =?us-ascii?Q?ijGWO4Y9QfZs1gA2NrdU+MFznhnZGmYbelZ7Y1In0lnkN7OtF6HRK5NSAWMI?=
 =?us-ascii?Q?AjeRJ6kuLvvR6SOCeqnRSqlVQtHtyHuJulHqTise1zaD6K6h/92lzbvGmVrS?=
 =?us-ascii?Q?Ph5Drmdzo2e6ZtYEuWoBV9bZySDpBn+lS5atzqh16HTqtA//rL5DVis9+XUJ?=
 =?us-ascii?Q?C5+84BTn7LUEV8I/18bSZULo9P+Fsw9u1xUncdnQ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bbe646c1-ce29-4ec4-5606-08daada93b84
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 05:59:19.0027
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nZrpLUh4rQsByi6UH60w6o4kgnCH0ZD7uYuLFwAuctFaNZXTUe/PjU8PaSwmyEVl6fcowsmuc+Jf/cRTQMuYig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6072
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 13, 2022 at 10:00:57PM +0800, Andrey Konovalov wrote:
> On Tue, Sep 27, 2022 at 4:42 AM Feng Tang <feng.tang@intel.com> wrote:
> >
> > > > @@ -746,7 +747,7 @@ static inline void slab_post_alloc_hook(struct kmem_cache *s,
> > > >         for (i = 0; i < size; i++) {
> > > >                 p[i] = kasan_slab_alloc(s, p[i], flags, init);
> > > >                 if (p[i] && init && !kasan_has_integrated_init())
> > > > -                       memset(p[i], 0, s->object_size);
> > > > +                       memset(p[i], 0, orig_size);
> > >
> > > Note that when KASAN is enabled and has integrated init, it will
> > > initialize the whole object, which leads to an inconsistency with this
> > > change.
> >
> > Do you mean for kzalloc() only? or there is some kasan check newly added?
> 
> Hi Feng,
> 
> I mean that when init is true and kasan_has_integrated_init() is true
> (with HW_TAGS mode), kasan_slab_alloc() initializes the whole object.
> Which is inconsistent with the memset() of only orig_size when
> !kasan_has_integrated_init(). But I think this is fine assuming SLAB
> poisoning happens later. But please add a comment.
 
I see now. Will add some comment. thanks!

- Feng

> Thanks!