Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp153594rwi; Thu, 13 Oct 2022 23:17:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6HYPgA75wft4b01YnvKcBEzNPgl+7HERtW81oy+KJ0xxqxPYMpkroSF7e+4j3ipppCwkvD X-Received: by 2002:a17:906:58cc:b0:78d:ce9c:3787 with SMTP id e12-20020a17090658cc00b0078dce9c3787mr2329339ejs.715.1665728263753; Thu, 13 Oct 2022 23:17:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665728263; cv=none; d=google.com; s=arc-20160816; b=nGLOn55OzpAzwN3o9vRCDU1mM/LSSvHFYd5OzquW98Mdo5gvB0qO/0wd7BVTdfox4C kvb8jyl57e0cICaYhai+3GsYsRgUMgLzkteM6G+ElrvaJ0GR2r59DxysSOAhRR4NQuEE oBB6hg4tndTHVIVnVM+UWtsUI5N87i+chLCUWgXNh7ggW8FXIq0mDBf5wqpC+2Zy3ss/ l+4UkJYD7qa9w1g2BnalUsB9wRxh7Vw3Jaj0AFlbv59/DOzxsFxcI9XRyDqqc7DgT2Ys /4MqEXtj51ZgbLg71xk6mmkA4JIIUm3V6JQfsD4CUlmD873fy+1T/b0dgbuF/vXA5nRl PYIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8/kUrhzgarudK5Zq6dzRn6XSrMTWXPdR5qMwOiGgdtg=; b=FF7DuE/RiXQMsWiVUe4qjl2MbYcZbnlam2jyG+IUGxwypHfpbuJn+PTUFsSbxEyBbt S0fJJcmt8h8B8nmnFkw0jcfUhp6mLmI3bbK0GGHzbzIeeelBKwBzT/wXBk2ZBbhsRal8 jF6TAFKIP3dKg8z+IDJySvfwONeKOsWQlMnVW5igKb4BoJs38M8yP8pUnn9jGL7qQM3s L2gzn/QDgwDWbCMdvUnpQNq4oFczZkxDhQMCxr4DRuOwfel89aBP4WTPxhmPgEIIe8tA b6ayLRBcH/dCvr74M5t9iACB8ckJkypZjaYZ1o3SKWHTLyPWHdp5FdU5chTfFfbA9psM ROMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AGxdNMhZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g14-20020a056402090e00b00450c1de6234si1892679edz.587.2022.10.13.23.17.17; Thu, 13 Oct 2022 23:17:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AGxdNMhZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbiJNGKX (ORCPT + 99 others); Fri, 14 Oct 2022 02:10:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229711AbiJNGKU (ORCPT ); Fri, 14 Oct 2022 02:10:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E544887F81; Thu, 13 Oct 2022 23:10:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 604E5B81FBE; Fri, 14 Oct 2022 06:10:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F0AEC433C1; Fri, 14 Oct 2022 06:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665727816; bh=CiefB9Bs7UdCwH3zk05eBuTxLD49fBRg6WyB1mAS/Yw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AGxdNMhZm8rMatlboAOXRBQ+27845QkClFJqntmo7HHGRn0yQ3iYkMcipgXo7ipmK X3O0Vo98Z9VayqUJxZoYmZwSynh758eJ5e/Nz2+UJ+SQhjGd8ebemUQFPx+zQzNtSU pBzRkSwofMsH55tzuHU67zS7hVaXD/yHlFA51l5UkYOM7XPl2ufPPHj5yt/5gpxLym uwcxppPsMCP/7ZhVDPtemToQdqw21Z7r16gjoaoHfRkQsYPCkRT2mQP2aMw8hQrDz0 CWTGD6ZPS/cVQCwAbMUBIDTCjmPa/AIHwxvGCstYf+Z4QIdR1opYRPoC8/RbqEW9U/ g+c5SYxc1sXAg== Date: Fri, 14 Oct 2022 11:40:00 +0530 From: Manivannan Sadhasivam To: Vidya Sagar Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, bhelgaas@google.com, mani@kernel.org, Sergey.Semin@baikalelectronics.ru, dmitry.baryshkov@linaro.org, linmq006@gmail.com, ffclaire1224@gmail.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com Subject: Re: [PATCH V5 0/3] PCI: designware-ep: Fix DBI access before core init Message-ID: <20221014061000.GA316241@thinkpad> References: <20221013175712.7539-1-vidyas@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221013175712.7539-1-vidyas@nvidia.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vidya, On Thu, Oct 13, 2022 at 11:27:09PM +0530, Vidya Sagar wrote: > This series attempts to fix the issue with core register (Ex:- DBI) accesses > causing system hang issues in platforms where there is a dependency on the > availability of PCIe Reference clock from the host for their core > initialization. > This series is verified on Tegra194 & Tegra234 platforms. > > Manivannan, could you please verify on qcom platforms? > Currently I'm on paternity leave this week and next. Will test/review the latest version once I'm back. Thanks, Mani > V5: > * Addressed review comments from Bjorn > * Changed dw_pcie_ep_init_complete() to dw_pcie_ep_init_late() > * Skipped memory allocation if done already. This is to avoid freeing and then > allocating again during PERST# toggles from the host. > > V4: > * Addressed review comments from Bjorn and Manivannan > * Added .ep_init_late() ops > * Added patches to refactor code in qcom and tegra platforms > > Vidya Sagar (3): > PCI: designware-ep: Fix DBI access before core init > PCI: qcom-ep: Refactor EP initialization completion > PCI: tegra194: Refactor EP initialization completion > > .../pci/controller/dwc/pcie-designware-ep.c | 125 +++++++++++------- > drivers/pci/controller/dwc/pcie-designware.h | 10 +- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 27 ++-- > drivers/pci/controller/dwc/pcie-tegra194.c | 4 +- > 4 files changed, 97 insertions(+), 69 deletions(-) > > -- > 2.17.1 > -- மணிவண்ணன் சதாசிவம்