Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp203738rwi; Fri, 14 Oct 2022 00:16:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4lbFNgTig/+xm089pdS18ZZhhlx0ygb7ge1q1Nn5DEcQd6WYcVGqx7ThZTtscVSsMlyf9O X-Received: by 2002:a17:907:7618:b0:78d:ad63:2828 with SMTP id jx24-20020a170907761800b0078dad632828mr2623118ejc.27.1665731766382; Fri, 14 Oct 2022 00:16:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665731766; cv=none; d=google.com; s=arc-20160816; b=ABCGmx7FqO6J5oBJiUdFcyCPG52z1fzp5cc0q08ufysU/isd3p8A+tFRx+FrEIKVT6 4zVVeqx8zvrVdV2h2lRptInefWh2Nr6WymHpDdqnwvPVt0fgnivHPHaJZdLQh+RDFNZN ud98d5cZ67pqi1QK1a2MY8wzipMi72bjBJLMWOjtq9NFxNUL1757WuyuVxZgpxXQCWDT qRkufrvRGIsMcNSa1THqWNAHyUbAoxVTJF28Z6sF2rf+VVKKdxbGPMVgfnSFPnma59J1 7i5nH9JIliQEluTPsqBY4d0IHe6S+D2y4MVME4XZfceZWDIAqWCjADI3Q1eyWOa1SLpe 3wFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=rGJW8FmQVrTypkbQPahhRBWXvkVorOgzQGv7MuMqoqs=; b=vUApjzBoitc6nhU0UcC7sjSZesL/kl38/so+W2EEy69acD3apLCPSyk6b7KTqmUnH6 T6K5QGZNSaNIooaMXuNDAqUCS7HD0XO3HFqhZFT/KQ4cvO7SvkGxKNO90NqSje8CjBBv 2/QLy4UV/qH13mqFspmgzI2T3H5MYAVysyUwQEpoJy/EOkhEiwCDFxPzSyxrdT6xayl9 r70NEjdUH0qNvEW+nyr/ErGjZyZD3Blql6JWugQ5wF7E+0J7t+X3kbTbL0EY/rYoIYRj CQFM+J7OONqrGAzSpXxqd8SL5j750rU9SVsDpJQ+Ahmy70ak1Ade1oMJEt9b4SuocNLr qlOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gh13-20020a170906e08d00b0073d84b10656si1559776ejb.322.2022.10.14.00.15.37; Fri, 14 Oct 2022 00:16:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229836AbiJNGdZ (ORCPT + 99 others); Fri, 14 Oct 2022 02:33:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbiJNGdX (ORCPT ); Fri, 14 Oct 2022 02:33:23 -0400 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D031416C202; Thu, 13 Oct 2022 23:33:21 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R521e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0VS6Wv3A_1665729197; Received: from 30.221.130.30(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0VS6Wv3A_1665729197) by smtp.aliyun-inc.com; Fri, 14 Oct 2022 14:33:18 +0800 Message-ID: <60a05006-0052-c5eb-8f53-e1ce9ab26142@linux.alibaba.com> Date: Fri, 14 Oct 2022 14:33:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH V2 5/5] cachefiles: add restore command to recover inflight ondemand read requests Content-Language: en-US To: Jia Zhu , dhowells@redhat.com, xiang@kernel.org Cc: linux-cachefs@redhat.com, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, yinxin.x@bytedance.com, Gao Xiang References: <20221014030745.25748-1-zhujia.zj@bytedance.com> <20221014030745.25748-6-zhujia.zj@bytedance.com> From: JeffleXu In-Reply-To: <20221014030745.25748-6-zhujia.zj@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/22 11:07 AM, Jia Zhu wrote: > Previously, in ondemand read scenario, if the anonymous fd was closed by > user daemon, inflight and subsequent read requests would return EIO. > As long as the device connection is not released, user daemon can hold > and restore inflight requests by setting the request flag to > CACHEFILES_REQ_NEW. > > Suggested-by: Gao Xiang > Signed-off-by: Jia Zhu > Signed-off-by: Xin Yin LGTM. Reviewed-by: Jingbo Xu -- Thanks, Jingbo