Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Oct 2022 10:15:19 +0300
From:   Matti Vaittinen <mazziesaccount@gmail.com>
To:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] =?iso-8859-1?Q?=A7tools?= =?iso-8859-1?Q?=3A?= iio:
 iio_generic_buffer: Fix read size
Message-ID: <Y0kMh0t5qUXJw3nQ@dc75zzyyyyyyyyyyyyycy-3.rev.dnainternet.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="mOhZbFKr2wlI1FAt"
Content-Disposition: inline
Precedence: bulk


--mOhZbFKr2wlI1FAt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

When noevents is true and small buffer is used the allocated memory for
holding the data may be smaller than the hard-coded 64 bytes. This can
cause the iio_generic_buffer to crash.

Following was recorded on beagle bone black with v6.0 kernel and the
digit fix patch:
https://lore.kernel.org/all/Y0f+tKCz+ZAIoroQ@dc75zzyyyyyyyyyyyyycy-3.rev.dn=
ainternet.fi/
using valgrind;

=3D=3D339=3D=3D Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyrig=
ht info
=3D=3D339=3D=3D Command: /iio_generic_buffer -n kx022-accel -T0 -e -l 10 -a=
 -w 2000000
=3D=3D339=3D=3D Parent PID: 307
=3D=3D339=3D=3D
=3D=3D339=3D=3D Syscall param read(buf) points to unaddressable byte(s)
=3D=3D339=3D=3D    at 0x496BFA4: read (read.c:26)
=3D=3D339=3D=3D    by 0x11699: main (iio_generic_buffer.c:724)
=3D=3D339=3D=3D  Address 0x4ab3518 is 0 bytes after a block of size 160 all=
oc'd
=3D=3D339=3D=3D    at 0x4864B70: malloc (vg_replace_malloc.c:381)
=3D=3D339=3D=3D    by 0x115BB: main (iio_generic_buffer.c:677)

Fix this by always using the same size for reading as was used for
data storage allocation.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>

---

This patch has been only tested with my kx022a sensor driver. Driver may
have some culprits(s) and my understanding regarding IIO and these tools
is limited so perhaps the hard-coded size of 64 bytes has perfectly
legitimate reason - in which case I would appreciate to hear the
reasoning so I could seek the problem from my driver. Also, I didn't add
the fixes-tag as I don't really know which commit has caused the problem
- as I am not 100% sure what the problem actually is and if I am just
fixing a symptom here.
---
 tools/iio/iio_generic_buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/iio/iio_generic_buffer.c b/tools/iio/iio_generic_buffer.c
index 2491c54a5e4f..f8deae4e26a1 100644
--- a/tools/iio/iio_generic_buffer.c
+++ b/tools/iio/iio_generic_buffer.c
@@ -715,12 +715,12 @@ int main(int argc, char **argv)
 				continue;
 			}
=20
-			toread =3D buf_len;
 		} else {
 			usleep(timedelay);
-			toread =3D 64;
 		}
=20
+		toread =3D buf_len;
+
 		read_size =3D read(buf_fd, data, toread * scan_size);
 		if (read_size < 0) {
 			if (errno =3D=3D EAGAIN) {

base-commit: 4fe89d07dcc2804c8b562f6c7896a45643d34b2f
--=20
2.37.3


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--mOhZbFKr2wlI1FAt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmNJDIIACgkQeFA3/03a
ocVehQf/XIQ0ICkmrTi+n5aEjFmdKGhSs62dWbL4jsnhmp5k9znUWu5FbggGrIS1
Zjhh2srQ9oec+88NUdEcIkupXIuHBW3rsoQTtlA3/Egi5D1sQeLjmikAvq5ps6AS
pVSohBswNh8QgKElzubyoKDN8bUKibbD3xj0oFeONKrN7q0wGlEHRb+e6qAY/HCq
5pVunzYHjzTvymqh6OFu7BYzF5P9+lUb5x/2WyKPR3RiCSdS71MYFV8+YjDCzpLA
K3Mv1/r5NNQh5mBw+6ydBDsO75Kl/uJBjS8sseGSxK8lBqp6YKA638Cy4IXLl6pg
pTOLgxnpUN3vlIw3OCJIEsm3i5OOpw==
=IFzV
-----END PGP SIGNATURE-----

--mOhZbFKr2wlI1FAt--