Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <42d12308-4777-47a7-a1ae-50dfada050cf@huawei.com>
Date:   Fri, 14 Oct 2022 10:20:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [Linuxarm] [PATCH 1/2] hisi_acc_vfio_pci: Add debugfs to
 migration driver
To:     Longfang Liu <liulongfang@huawei.com>,
        <alex.williamson@redhat.com>, <jgg@nvidia.com>,
        <shameerali.kolothum.thodi@huawei.com>
CC:     <cohuck@redhat.com>, <linux-kernel@vger.kernel.org>,
        <linuxarm@openeuler.org>
References: <20221014025757.39415-1-liulongfang@huawei.com>
 <20221014025757.39415-2-liulongfang@huawei.com>
From:   John Garry <john.garry@huawei.com>
In-Reply-To: <20221014025757.39415-2-liulongfang@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14/10/2022 03:57, Longfang Liu wrote:
> +static void hisi_acc_vf_debugfs_init(struct hisi_acc_vf_core_device *hisi_acc_vdev)
> +{
> +	struct pci_dev *vf_pdev = hisi_acc_vdev->vf_dev;
> +	struct device *dev = &vf_pdev->dev;
> +	int ret;
> +
> +	if (!atomic_read(&hisi_acc_root_ref))
> +		hisi_acc_debugfs_root = debugfs_create_dir("hisi_vfio_acc", NULL);
> +	atomic_inc(&hisi_acc_root_ref);
> +

This looks totally racy, such that I wonder why even bother using an 
atomic for hisi_acc_root_ref. Indeed, why is hisi_acc_debugfs_root not 
created in the driver module init?

Thanks,
John