Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0df72f8e-1c17-2140-c841-5a75fb43db14@amd.com>
Date:   Fri, 14 Oct 2022 15:26:07 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2] perf: Rewrite core context handling
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     acme@kernel.org, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, namhyung@kernel.org, songliubraving@fb.com,
        eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com,
        frederic@kernel.org, maddy@linux.ibm.com, irogers@google.com,
        will@kernel.org, robh@kernel.org, mingo@redhat.com,
        catalin.marinas@arm.com, ndesaulniers@google.com,
        srw@sladewatkins.net, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com, kim.phillips@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20221008062424.313-1-ravi.bangoria@amd.com>
 <Y0VTn0qLWd925etP@hirez.programming.kicks-ass.net>
 <ba47d079-6d97-0412-69a0-fa15999b5024@amd.com>
 <Y0V3kOWInrvCvVtk@hirez.programming.kicks-ass.net>
 <Y0WsRItHmfI5uaq3@hirez.programming.kicks-ass.net>
 <174fb540-ec18-eeca-191d-c02e1f1005d2@amd.com>
 <Y0awHa8oS5yal5M9@hirez.programming.kicks-ass.net>
 <Y0cn1xazYpNmqhRo@hirez.programming.kicks-ass.net>
 <99caec5f-dcdf-70c6-8909-11552ce42a20@amd.com>
 <Y0fvpQEEl/tK6mJ5@hirez.programming.kicks-ass.net>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <Y0fvpQEEl/tK6mJ5@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0NOWllnaEhkR0h3dSs3NUJady9ObktrcmFMOXZkVTNvamxPY2UxeG5iVEF4?=
 =?utf-8?B?eHplMkUrQVRZNjJtN2xmMU9tVDNBWm5scUhPZDEwSnB3STFxdEx1aUxYT2Jn?=
 =?utf-8?B?dkRheEpCTENEd05iVHluRHRaSHIwV2hUZSs0MEdKVCtVZ3lrTm8xSVViQVlV?=
 =?utf-8?B?WHhrK21yNGdaUTZpL2tZcnUyejdpN21zWjYwWFFyaWhyU1lhNGh2SSt4VzRL?=
 =?utf-8?B?SzV1VmJTZUVrZThqaUZmTVRhT3JJU1piZGtjUmxiaXdZOFBEM05FNjYwV1hQ?=
 =?utf-8?B?ZTVaK0lYcnR2allLZDN2b0hyM25BUFI4NEJzUks5NVF0TENmb0VDSHc2WEt6?=
 =?utf-8?B?SEVJSEUwY0VnL0ZZVUgzOGRpSkRpeHo3Tk8wdjhnSExmUDlVRXJsaWp1Vlpl?=
 =?utf-8?B?b1VFRjM5UldPUWpKT0MwOGs5bzN6SDF4dExONW80VnFmWGhvakp0TS9CbHh1?=
 =?utf-8?B?TlNiRE9QdDBSUCsrV21uSkszSFZFOC9FTEpoMHN4Vk1SMXNnblBCbWwxRnFi?=
 =?utf-8?B?K0lKUFVwVUlwdVd2UUd3ekUxVUh4czBlUm03dEt6ZUtIaEJNMHlHRXlsWS9R?=
 =?utf-8?B?aUxyQkZVOUlRQ2pram5pZjh6SDhvM3R4ZDFlK0F6SjBkSTcybms1ZTZaVE52?=
 =?utf-8?B?TGpJZ1RwdVFsYm8xSnN5ME00Ty9yYW55RC85MHBDYXdzdVUrYXQzRituZjJC?=
 =?utf-8?B?RlRJZHRHQ2hrRWZSSjFGajVpWk9nb1RXMGtPN2JJSW5uaG1rOXVuMWsycHVU?=
 =?utf-8?B?WHhidFFUdnBpMmx2b1NzakI2dFlmOHE5YXJ3TXdudlBrTk5rVHkzbjhYOG00?=
 =?utf-8?B?RUM1a1lRdEFpV282RXdnUU9mNWc3RTA4cjNwamlSU2RSeWZGem5rM3QzbTdC?=
 =?utf-8?B?Mm1qdE1yaW5ablpEQ3d4RGNhdVNwOGF2NTVaaDB4Z0phcGNBVStKQmNua1U4?=
 =?utf-8?B?bTNKN0NRMllhQ3RiL3VnWVFuNUFSODFBc2V3eWVjVW00WXRpZ0xKQlBOT1BH?=
 =?utf-8?B?YjArUmJtMVJzR3Y1all1WWQxOEY5NWlhSG9hSlFOYlFvY1FJbEptNHQwVzcv?=
 =?utf-8?B?RnY0aVVjRjY5NGllbkJGeFBuajJaMDhmalZ3ck1qYU5xYTcybUVYTml4WHZk?=
 =?utf-8?B?K3R1ZVlqYWgxcXlGUi9JQXpyazdrRkpMVXV6NklaYThZOXpCYVp1N21XcFZa?=
 =?utf-8?B?M3Z2K2RiandDUVJwcVdNRjIvUDUrTCtRTzE0eHdYYnRNSUlwUzFkTVh1ZVRP?=
 =?utf-8?B?ZDhqOWNXZUFTOEMya2VuLzhJRlZaZGlMaHBjU1BabTBKeWY4bkR1bnFzd29v?=
 =?utf-8?B?eThsU0dqM2FyZjhjbE15aE1pbzFVaE81L1cvbVM3ekFsNHVKRnhIK0lrTmxk?=
 =?utf-8?B?dWdOVU9WeC8vcXRjQTdoT1o4cnYrODhTaXkrQmtlUjExeTJtQ0JiWDhaYlAy?=
 =?utf-8?B?bU9VK3dDOUUySEFKMy9rV3R1dyt1SUx0Y3ZjYlFRZHNMUzF3M3IxWHNnTE9I?=
 =?utf-8?B?VGVNODBpVUkwV3crUHpvVUM2NW5OUU94VE02UmZOQUx5Qk5uZUJNeFBmckE2?=
 =?utf-8?B?eE4vSjFnS2lDZTlrbFBPSFV2bUsrMkFVRHo0WmNMVC9EbzFGaDkweW43cVNQ?=
 =?utf-8?B?ZXMwRUYwTW5pNzFPdzlXMmdFYzhUTG4xMExBckNYV1pkQldSdStLUlo4aFdU?=
 =?utf-8?B?VVU2YXlKV0p6T1N5b1VtVWFvTllNeURWVXZTYllnSStHNlQzM3kzWEhwV0ZM?=
 =?utf-8?B?T1ZRSXE2b01zU2QxZnhlTmlTaXBXaHY4eG9YSHprZm9HaG5Wd2JUY05hMUNn?=
 =?utf-8?B?Vkc1MVhQODFZOWk0dS9waUpHVlB1RFNKMEZHeU5GOGxFcmxuZWdvTndIODl5?=
 =?utf-8?B?UDE2NjlRelRkWVZkZWVQUkViQm54QkFqR0w1TExoTmF5UGt4eExXSXl3b3Yw?=
 =?utf-8?B?L21rZit4YUFFbkdPSjcyL1B6UGdvUEp3UW1Vd2Y0NDN6dTIzcnNqMEc4U1pW?=
 =?utf-8?B?cjRNNWg2b1BOZXVJdkdWWlh3QmR1SlVyM1lVVythVWpGRWxGMGVFOWlNdjZm?=
 =?utf-8?B?VUp3U29yckV6eDlmWG1LUisrMXVnckV4MWJ1MXZIVTExcEJTUDNtMlBCOGdS?=
 =?utf-8?Q?GakYDz8NiV37IdbxsJOO3nF95?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b205332-43a0-4423-0a78-08daadca5a7f
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 09:56:24.3057
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QoHjFVTRkZP7ibTAu8VF1fsK0giXuyGyZdoMUa9CKk5M/jmRq35efmjJX0lGe7vXP7wI7R1U3wq2giX2GkWHnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7698
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13-Oct-22 4:29 PM, Peter Zijlstra wrote:
> On Thu, Oct 13, 2022 at 03:37:23PM +0530, Ravi Bangoria wrote:
> 
>>> -	refcount_t			refcount;
>>> +	refcount_t			refcount; /* event <-> ctx */
>>
>> Ok. We need to remove all those // XXX get/put_ctx() from code
>> which we added to make refcount a pmu_ctx <-> ctx.
> 
> Them already gone :-) I've not yet fixed up the typoes, but current
> version should be here:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=perf/core
> 
> Thanks!

I've been running perf-fuzzer on Xeon machine since yesterday and I don't see any
issue. Will do the same on my AMD machine as well over the weekend.

Thanks,
Ravi