Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp397828rwi; Fri, 14 Oct 2022 03:44:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7WCAOx8P2AxOhq8gC3nDgYdd31F3GZvpqOeTkqG860Pht7kBt875Un/jpIj72MriP2XC9D X-Received: by 2002:a63:54b:0:b0:464:8e6:11e7 with SMTP id 72-20020a63054b000000b0046408e611e7mr4113677pgf.212.1665744272028; Fri, 14 Oct 2022 03:44:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665744272; cv=none; d=google.com; s=arc-20160816; b=EEZfEfkziexMrnm7GF1os14YKEkyNbItZHtd8avp80ZiufR0bjaBs3Nq+omSJT4ikI eKdpp1NJtgwsUH9aIQffJtvaMU+kOWwN2uWjiZIhKfvXNL5lGofwOiFGFt4k1I3Hs3YA ARyFYctO7xD/8mqm14gaE4zvE3xyfOxWRmosF7GKoSzaoCJKjx4sRW+5/Dxg6/tN4SmJ RH+Wfm9EVH07iECNFN040MPibjJaXMOMeEzZsYnWJoJaslIfligxou+g6iD8wNJP87mO Bye4wPQ45J9YC8p9/T5DPzb02VW22BP6+h/BIqsxEtWd/R9/j1UiAlsqF4rr7jJzX/+P 9DtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mGQAc4DNuLNyGMuufd17Yt+iI/vmJZaLb5KHqsYzRAk=; b=foLvYMtchvpaNuOsU6W2QDXmHHAC7rdbAHq4yZ/CLDnAop2MWfMIww9UeK0ezypznW 4ibyuD7jBnnnNmZGM7zjBd9k+pFBGGR/uB8fqkF6Q1Fgn0Wd/A1KIz/6W0tyth1oQwkt aarF7i7eOVEYvmYEv1r1fLilyx1LUYpBB4HrA2Cea4kg2eZ88/rTGcsmJgvDYR5UJwWA xeBifS254LNBO4D+u52cgIZDfOAvugnqjRB1k9juiZ7bQPo1LYPF42zzQU0uVuzWyF87 ne5/oZwxDc52pTVLgaOSS92w8IYKh1vOvdQP7N1aalhmALKDXdR4eghcV7kk4xvtOJwn z5Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eQofEcQc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 5-20020a621605000000b005631f695371si2087638pfw.127.2022.10.14.03.44.19; Fri, 14 Oct 2022 03:44:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eQofEcQc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229462AbiJNKb7 (ORCPT + 99 others); Fri, 14 Oct 2022 06:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbiJNKb5 (ORCPT ); Fri, 14 Oct 2022 06:31:57 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26E9F252BF; Fri, 14 Oct 2022 03:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665743516; x=1697279516; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ptDZqIUqk3munuUKVxS0oc3Bl5qrSZ+Czm3phxJrSjQ=; b=eQofEcQcBRytGBhdtkNtgtCCqEubujQsksvsPcYThFSDLHWantJhmwG2 xQdMoWrk74weH0brIBzLBfVMGPnqPi9zAIqLl+dB/GJj6tBt0eaJull+2 NgNa46Fq49w6rvFADQjSw1ihDgLZA2rDpKCrVQ7lz398T0sY+B/mmWflH v+rm5JzZIRCHugLo1BfKnjCruNMubmBFLdZKkZeVRKw7ifM6OB1mR6QgK CuWXKejITuKzk5wdYofrkGlJcoRQ0z2WyJi0+KuJPIVeL39fB8t/uqJ+z ul5CF8j3DKtMCevVrOM0gNan+AGV1lfyHOM4AUWmBQxp+HL6FY/ZduTIa w==; X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="304083164" X-IronPort-AV: E=Sophos;i="5.95,184,1661842800"; d="scan'208";a="304083164" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2022 03:31:55 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="660688519" X-IronPort-AV: E=Sophos;i="5.95,184,1661842800"; d="scan'208";a="660688519" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2022 03:31:52 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 370C720146; Fri, 14 Oct 2022 13:31:50 +0300 (EEST) Date: Fri, 14 Oct 2022 10:31:50 +0000 From: Sakari Ailus To: "Lad, Prabhakar" Cc: Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Shawn Tu , Jacopo Mondi , Randy Dunlap , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das , Lad Prabhakar Subject: Re: [PATCH] media: i2c: ov5645: Use runtime PM Message-ID: References: <20220927201634.750141-1-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On Wed, Oct 12, 2022 at 07:55:25PM +0100, Lad, Prabhakar wrote: > On a closer look, I can move the above after registering the subdev, > but I can get rid of err_pm_runtime label as PM is enabled further up > the code path to detect the senosr. > > If you are OK with this i'll post a v2 along with the below two > patches + the suggestions you mentioned earlier on this patch. Sounds good to me. -- Sakari Ailus