Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Oct 2022 13:36:03 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vivek Yadav <vivek.2311@samsung.com>
Cc:     rcsekar@samsung.com, wg@grandegger.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        pankaj.dubey@samsung.com, ravi.patel@samsung.com,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] can: mcan: Add support for handling DLEC error on CAN
 FD
Message-ID: <20221014113603.hrg3ttsgofgq44ba@pengutronix.de>
References: <CGME20221014053017epcas5p359d337008999640fa140c691f47bc79c@epcas5p3.samsung.com>
 <20221014050332.45045-1-vivek.2311@samsung.com>
 <20221014071114.a6ls5ay56xk4cin3@pengutronix.de>
 <00db01d8dfbf$5e38fbd0$1aaaf370$@samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mj7nepgaiz77tn2a"
Content-Disposition: inline
In-Reply-To: <00db01d8dfbf$5e38fbd0$1aaaf370$@samsung.com>
Precedence: bulk


--mj7nepgaiz77tn2a
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 14.10.2022 16:53:19, Vivek Yadav wrote:
> >=20
> >                 if (is_lec_err(lec))
> >                         work_done +=3D m_can_handle_lec_err(dev, lec);
> >=20
> >                 if (is_lec_err(dlec))
> >                         work_done +=3D m_can_handle_lec_err(dev, dlec);
> >=20
> > > +			u8 dlec =3D FIELD_GET(PSR_DLEC_MASK, psr);
> > > +
> > > +			if (is_lec_err(dlec)) {
> > > +				netdev_dbg(dev, "Data phase error
> > detected\n");
> >=20
> > If you add a debug, please add one for the Arbitration phase, too.
>
> I have added the debug print specially for dlec (data phase). So we
> can differentiate lec errors (for all type of frames except FD with
> BRS) and Data phase errors, as we are calling same handler function
> for both the errors.
>=20
> If I understood your comment correctly, you are asking something like bel=
ow:
>         /* handle protocol errors in arbitration phase */
>         if ((cdev->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING) &&
> -           m_can_is_protocol_err(irqstatus))
> +           m_can_is_protocol_err(irqstatus)) {
> +               netdev_dbg(dev, "Arbitration phase error detected\n");
>                 work_done +=3D m_can_handle_protocol_error(dev, irqstatus=
);
> +       }
>=20
> If the above implementation is correct as per your review comment, I
> think we don't need the above changes because Debug print for
> arbitration failure are already there in "
> m_can_handle_protocol_error" function.

Ok

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--mj7nepgaiz77tn2a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmNJSaEACgkQrX5LkNig
011yxgf/c6acNcBfDRfZ9nhxnau0jXG2K7yOwJb8Hi4SIxPO/63RPFT+lqGvm+Pn
eA75SQiGy8ojstW3XJyGDTm5hJ0YNHN1jEd00ZlY4LuBwTmoNrsdMigxjbpLOAdp
orkIkDcbsL6TNx37Ky38actcIhNVJ9MognLme0WG/2Z3AA9iEQHpV1RmBe1a3rxQ
TDpUo9iK8juT9CtH7A54MPEmeFJnIiHTC4sOBD5fX9e8iaTiqQS73UP8O6R3M8LG
AHDywbXMHeCVI8M/mPP2iY11q58D2omCh6J7lD0VpiycpWEycGaGp+n52S33FaEX
BFx4blHBGw7XsfT2KbGaZm52yweSWw==
=UAXg
-----END PGP SIGNATURE-----

--mj7nepgaiz77tn2a--