Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Oct 2022 14:03:34 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Li zeming <zeming@nfschina.com>
Cc:     krisman@collabora.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unicode: mkutf8data: Add malloc return value detection
Message-ID: <Y0leJgPmNrqeZP37@casper.infradead.org>
References: <20221014075710.310943-1-zeming@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221014075710.310943-1-zeming@nfschina.com>
Precedence: bulk

On Fri, Oct 14, 2022 at 03:57:10PM +0800, Li zeming wrote:
> Add the check and judgment statement of malloc return value.

Why?  Just to shut up some static checker?

> +++ b/fs/unicode/mkutf8data.c
> @@ -495,6 +495,9 @@ static struct node *alloc_node(struct node *parent)
>  	int bitnum;
>  
>  	node = malloc(sizeof(*node));
> +	if (unlikely(!node))
> +		return NULL;
> +

Right, so now alloc_node() can return NULL when it couldn't before.
Look at the callers ...

        while (keybits) {
                if (!*cursor)
                        *cursor = alloc_node(node);
                node = *cursor;
                if (node->nextbyte)
                        key++;

They're unprepared for alloc_node() to return NULL, so all you've done
is move the crash.