Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Oct 2022 15:02:20 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vivek Yadav <vivek.2311@samsung.com>
Cc:     rcsekar@samsung.com, wg@grandegger.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        pankaj.dubey@samsung.com, ravi.patel@samsung.com,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] can: mcan: Add support for handling DLEC error on CAN
 FD
Message-ID: <20221014130220.jfdldo644aq5x6ox@pengutronix.de>
References: <CGME20221014121257epcas5p3805649d1a77149ac4d3dd110fb808633@epcas5p3.samsung.com>
 <20221014114613.33369-1-vivek.2311@samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="nsyareichhihttzn"
Content-Disposition: inline
In-Reply-To: <20221014114613.33369-1-vivek.2311@samsung.com>
Precedence: bulk


--nsyareichhihttzn
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 14.10.2022 17:16:13, Vivek Yadav wrote:
> When a frame in CAN FD format has reached the data phase, the next
> CAN event (error or valid frame) will be shown in DLEC.
>=20
> Utilizes the dedicated flag (Data Phase Last Error Code: DLEC flag) to
> determine the type of last error that occurred in the data phase
> of a CAN FD frame and handle the bus errors.

Can you please test your code before sending it.

| drivers/net/can/m_can/m_can.c: In function =E2=80=98m_can_handle_bus_erro=
rs=E2=80=99:
| include/linux/build_bug.h:16:51: error: negative width in bit-field =E2=
=80=98<anonymous>=E2=80=99
|    16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e));=
 })))
[...]
| drivers/net/can/m_can/m_can.c:883:17: warning: ISO C90 forbids mixed decl=
arations and code [-Wdeclaration-after-statement]
|   883 |                 u8 dlec =3D FIELD_GET(PSR_DLEC_MASK, psr);
|       |                 ^~

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--nsyareichhihttzn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmNJXdkACgkQrX5LkNig
010E+ggAr4/hTIGmZRl7ym8KMWr1saLyszKV4xOnKcuQNMW9IR4eDH0jVoLnSIur
zfkSEEIfjZWMRJhHu4h2iIV6YnkBz0jZa5rMnDG63LSYJOl2UT1yBNzo1MBFjhhs
JSLdk069k9y1R2oAZ0Madks2vkHN42HHqOXG4/c7aa/vAMK8mHIws4z16nMonF0x
fsfwzm8QXhKSdzQ3vVJkbupFKoUe7a+FB5dOKlG1oOqTCXY2CEKz553qPP8le8Ql
w5mFYCOWBhy5ESxuIBFDQA0+MiCmeuFgGNZiULHQAd0dU1ROmBI9VKFTOkNXxeXU
XHZfHqoLfscfXRyzKOefhrBVb/X5jw==
=XetC
-----END PGP SIGNATURE-----

--nsyareichhihttzn--