Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Oct 2022 20:09:59 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     daniel.lezcano@linaro.org, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] clocksource/drivers/timer-ti-dm: Fix some
 kernel-doc comments
Message-ID: <Y0lfpxXZZZuiI4A8@debian.me>
References: <20221014091357.64504-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="qqNtyi/bdFWrjAqo"
Content-Disposition: inline
In-Reply-To: <20221014091357.64504-1-yang.lee@linux.alibaba.com>
Precedence: bulk


--qqNtyi/bdFWrjAqo
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 14, 2022 at 05:13:57PM +0800, Yang Li wrote:
> Fix some kernel-doc comments.
>=20
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D2399

What fix are you doing below? Please describe (should contain warning
messages from bugzilla link above).

---- ranting ----
When I see social media posts, I often see "Link in bio" phrase. That
is, instead of posting the full link, the link is placed on URL section
of a poster's bio and a pointer to it is phrased in relevant posts. What
if such "link in bio" link changes? The older posts which points to
different link than in the bio become irrelevant.

I would rather just spell the full link in my posts instead for
posterity.
---- end ranting ----

> diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/time=
r-ti-dm.c
> index cad29ded3a48..574c88584fbf 100644
> --- a/drivers/clocksource/timer-ti-dm.c
> +++ b/drivers/clocksource/timer-ti-dm.c
> @@ -181,8 +181,7 @@ static inline u32 dmtimer_read(struct dmtimer *timer,=
 u32 reg)
>  /**
>   * dmtimer_write - write timer registers in posted and non-posted mode
>   * @timer:      timer pointer over which write operation is to perform
> - * @reg:        lowest byte holds the register offset
> - * @value:      data to write into the register
> + * @val:      data to write into the register
>   *
>   * The posted mode bit is encoded in reg. Note that in posted mode, the =
write
>   * pending bit must be checked. Otherwise a write on a register which ha=
s a
> @@ -925,7 +924,7 @@ static int omap_dm_timer_set_int_enable(struct omap_d=
m_timer *cookie,
> =20
>  /**
>   * omap_dm_timer_set_int_disable - disable timer interrupts
> - * @timer:	pointer to timer handle
> + * @cookie:	pointer to omap dm timer handle
>   * @mask:	bit mask of interrupts to be disabled
>   *
>   * Disables the specified timer interrupts for a timer.

Seems like two different fixes, right? These should be splitted into its
own patch.

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--qqNtyi/bdFWrjAqo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY0lfpwAKCRD2uYlJVVFO
o3csAQCWz9VFu9TGcgBSLP9v85LV+TmGBJjg9g+6qNxBmR3PHgEAuMJnfWmCDGLx
py8SAfX5G1u4AiGNzxZ3GFg3hz3kYQw=
=GOSp
-----END PGP SIGNATURE-----

--qqNtyi/bdFWrjAqo--