Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jonathan Corbet <corbet@lwn.net>
To:     Carlos Bilbao <carlos.bilbao@amd.com>,
        Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bilbao@vt.edu, ojeda@kernel.org
Subject: Re: [PATCH 2/2] Documentation: Add HOWTO Spanish translation into
 rst based build system
In-Reply-To: <c351e1f6-29ad-2b93-09e4-c7f9d038d112@amd.com>
References: <20221013184816.354278-1-carlos.bilbao@amd.com>
 <20221013184816.354278-3-carlos.bilbao@amd.com>
 <Y0kqHBwaYvZwTp9M@debian.me>
 <c351e1f6-29ad-2b93-09e4-c7f9d038d112@amd.com>
Date:   Fri, 14 Oct 2022 07:57:50 -0600
Message-ID: <87sfjqh5i9.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Carlos Bilbao <carlos.bilbao@amd.com> writes:

> On 10/14/22 04:21, Bagas Sanjaya wrote:
>
>> =C2=A1Hola Carlos! Gracias for start writing Spanish translations. Howev=
er,
>> the patch can be improved, see below.
> Hola Bagas, thanks for your feedback :)
>>
>> On Thu, Oct 13, 2022 at 01:48:16PM -0500, Carlos Bilbao wrote:
>>> This commit adds Spanish translation of HOWTO document into rst based
>>> documentation build system.
>>>
>> Better say "Translate HOWTO document into Spanish".
> So, for the commit message here I just replicated what prior folks did,
> see:
>
> For Japanese:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit=
/Documentation/translations/ja_JP?h=3Dv6.0&id=3Df012733894d36ff687862e9cd3b=
02ee980c61416
>
> For Korean:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit=
/Documentation/translations/ko_KR/howto.rst?h=3Dv6.0&id=3Dba42c574fc8b803ec=
206785b7b91325c05810422
>
> I think I will leave that commit message, it is slightly more informative
> than "Translate HOWTO document into Spanish".

Just so you know, the standard advice (as found in submitting-patches.rst)=
=20
is to use the imperative mode in changelogs.  Some maintainers are quite
insistent that things be done that way.  I'm not one of those, though,
so I think the existing message is fine.

Thanks,

jon