Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764123AbXF1Css (ORCPT ); Wed, 27 Jun 2007 22:48:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762605AbXF1Csk (ORCPT ); Wed, 27 Jun 2007 22:48:40 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:44320 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760508AbXF1Csj (ORCPT ); Wed, 27 Jun 2007 22:48:39 -0400 Date: Wed, 27 Jun 2007 21:48:22 -0500 From: "Serge E. Hallyn" To: James Morris Cc: "Serge E. Hallyn" , Kyle Moffett , Andreas Gruenbacher , Chris Wright , linux-security-module@vger.kernel.org, Andrew Morgan , Andrew Morton , Stephen Smalley , lkml , Arjan van de Ven , Greg KH , Eric Paris Subject: Re: [PATCH try #2] security: Convert LSM into a static interface Message-ID: <20070628024822.GA11276@sergelap.austin.ibm.com> References: <200706252237.59226.agruen@suse.de> <11C35822-4E11-4365-BADE-C1AE41F15B50@mac.com> <20070626134712.GA8615@sergelap.austin.ibm.com> <20070627134149.GB2679@sergelap> <20070627172102.GB16764@sergelap.austin.ibm.com> <20070627185125.GA17059@sergelap.austin.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 926 Lines: 22 Quoting James Morris (jmorris@namei.org): > On Wed, 27 Jun 2007, Serge E. Hallyn wrote: > > > Patch tests fine for me for expected capability behavior with lsm=n, > > lsm=y, lsm=y+capability=y, lsm=y+selinux=y, and lsm=y+caps=y+selinux=y. > > > > So while I'm opposed to the patch, it appears to be safe. > > I've also tested a bunch of scenarios: allmodconfig, lsm=y,cap=n, > selinux=y,cap=n etc. I was wondering about the uninlining of all those functions, so did a set of performance runs. Found no statistically relevant change in dbench, tbench, or reaim. (tried to run kernbench too but the benchmark failed somewhere and i didn't care enough to look into it) -serge - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/